Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Sync from noir #9242

Closed
wants to merge 3 commits into from
Closed

feat: Sync from noir #9242

wants to merge 3 commits into from

Conversation

AztecBot
Copy link
Collaborator

Automated pull of development from the noir programming language, a dependency of Aztec.
BEGIN_COMMIT_OVERRIDE

END_COMMIT_OVERRIDE

@TomAFrench TomAFrench mentioned this pull request Oct 15, 2024
Closed
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 15, 2024 •
edited
Loading

Changes to public function bytecode sizes

Generated at commit: 63bef728ca21022ea0152ad118c26ae0dfa0b99d, compared to commit: 5a3a8ccd0286a16b93c95a1de21676250926456a

🧾 Summary (100% most significant diffs)

Program Bytecode size in bytes (+/-) %
TokenBlacklist::public_dispatch +106,091 ❌ +441.51%
AuthRegistry::public_dispatch +15,594 ❌ +203.66%
Lending::public_dispatch +50,140 ❌ +197.53%
Auth::public_dispatch +19,621 ❌ +191.26%
AuthRegistry::consume +5,409 ❌ +189.86%
TokenBlacklist::transfer_public +9,140 ❌ +153.48%
Lending::update_accumulator +7,706 ❌ +150.65%
Token::public_dispatch +38,318 ❌ +142.42%
TokenBlacklist::mint_public +5,497 ❌ +133.62%
AvmTest::add_storage_map +2,242 ❌ +113.81%
TokenBlacklist::update_roles +7,658 ❌ +110.19%
NFT::mint +3,028 ❌ +103.70%
Lending::_borrow +7,517 ❌ +102.68%
Token::transfer_public +4,667 ❌ +101.86%
TokenBlacklist::constructor +7,092 ❌ +92.95%
CardGame::public_dispatch +13,497 ❌ +92.07%
Test::public_dispatch +15,622 ❌ +90.68%
TokenBlacklist::shield +5,349 ❌ +88.88%
NFT::public_dispatch +18,256 ❌ +87.12%
Auth::set_authorized +4,685 ❌ +86.30%
Auth::set_authorized_delay +4,569 ❌ +85.42%
Lending::_repay +4,254 ❌ +83.28%
TokenBlacklist::burn_public +4,245 ❌ +76.45%
FeeJuice::public_dispatch +4,271 ❌ +76.21%
Lending::_withdraw +5,377 ❌ +72.89%
Token::shield +3,462 ❌ +70.15%
Token::mint_public +2,158 ❌ +69.66%
AuthRegistry::set_authorized +1,201 ❌ +69.58%
AuthRegistry::_set_authorized +1,202 ❌ +68.61%
AvmTest::public_dispatch +36,473 ❌ +68.57%
AvmTest::set_storage_map +1,126 ❌ +67.10%
AuthRegistry::is_consumable +1,208 ❌ +65.90%
StatefulTest::public_dispatch +4,839 ❌ +65.68%
Lending::get_position +2,983 ❌ +64.33%
TokenBridge::public_dispatch +12,111 ❌ +62.65%
AppSubscription::constructor +2,262 ❌ +60.18%
AppSubscription::public_dispatch +2,981 ❌ +59.51%
Test::consume_mint_public_message +4,858 ❌ +56.80%
Uniswap::_approve_bridge_and_exit_input_asset_to_L1 +3,197 ❌ +56.34%
TokenBlacklist::mint_private +2,105 ❌ +55.97%
EasyPrivateVoting::public_dispatch +3,280 ❌ +55.62%
EasyPrivateVoting::add_to_tally_public +1,206 ❌ +55.22%
NFT::constructor +2,540 ❌ +53.37%
Token::constructor +2,686 ❌ +52.65%
Token::burn_public +2,353 ❌ +52.58%
FeeJuice::_increase_public_balance +1,101 ❌ +49.13%
Token::mint_private +1,429 ❌ +48.31%
TokenBridge::claim_public +4,658 ❌ +47.06%
NFT::transfer_in_public +1,540 ❌ +43.61%
Benchmarking::public_dispatch +2,011 ❌ +42.58%
Router::public_dispatch +1,128 ❌ +41.49%
Crowdfunding::init +1,467 ❌ +40.61%
Spam::public_spam +974 ❌ +40.21%
PriceFeed::public_dispatch +1,407 ❌ +39.88%
Uniswap::public_dispatch +8,842 ❌ +38.15%
TokenBlacklist::get_roles +923 ❌ +37.98%
TokenBlacklist::_increase_public_balance +927 ❌ +37.68%
Token::_increase_public_balance +927 ❌ +37.68%
NFT::owner_of +883 ❌ +36.78%
InclusionProofs::public_dispatch +1,508 ❌ +36.58%
Spam::public_dispatch +1,215 ❌ +36.30%
InclusionProofs::constructor +989 ❌ +36.28%
Claim::constructor +1,188 ❌ +35.82%
Crowdfunding::public_dispatch +2,133 ❌ +35.37%
Claim::public_dispatch +1,424 ❌ +33.66%
Test::consume_message_from_arbitrary_sender_public +2,165 ❌ +33.35%
StaticChild::public_dispatch +916 ❌ +33.15%
AvmTest::bulk_testing +7,754 ❌ +32.71%
EasyPrivateVoting::constructor +1,070 ❌ +32.23%
FPC::constructor +956 ❌ +30.28%
Uniswap::constructor +956 ❌ +30.28%
Auth::constructor +958 ❌ +30.15%
PrivateFPC::constructor +890 ❌ +28.22%
PrivateFPC::public_dispatch +1,131 ❌ +27.84%
TokenBridge::constructor +886 ❌ +26.88%
Benchmarking::increment_balance +782 ❌ +26.85%
TestLog::emit_unencrypted_events +450 ❌ +26.79%
Parent::public_dispatch +2,124 ❌ +26.48%
FPC::public_dispatch +2,164 ❌ +24.68%
StaticParent::public_dispatch +1,309 ❌ +23.33%
Token::complete_refund +627 ❌ +22.98%
AvmTest::sha256_hash +636 ❌ +21.71%
StatefulTest::public_constructor +747 ❌ +21.48%
CardGame::start_game +1,199 ❌ +19.70%
TestLog::public_dispatch +502 ❌ +17.00%
CardGame::on_card_played +838 ❌ +16.53%
Test::create_l2_to_l1_message_public +330 ❌ +16.50%
DocsExample::public_dispatch +779 ❌ +15.57%
AvmTest::u128_addition_overflow +182 ❌ +15.49%
TokenBridge::exit_to_l1_public +1,023 ❌ +15.18%
Auth::get_scheduled_authorized +243 ❌ +14.73%
Auth::get_authorized +252 ❌ +14.47%
AvmTest::pedersen_hash_with_index +375 ❌ +12.39%
AvmTest::pedersen_hash +375 ❌ +12.39%
Lending::_deposit +270 ❌ +12.22%
CardGame::on_cards_claimed +799 ❌ +11.97%
FeeJuice::set_portal +108 ❌ +11.88%
Token::assert_minter_and_mint +243 ❌ +10.97%
NFT::_finish_transfer_to_public +174 ❌ +10.77%
StatefulTest::increment_public_value +193 ❌ +10.73%
NFT::set_minter +193 ❌ +10.54%
Token::set_minter +193 ❌ +10.54%
NFT::is_minter +180 ❌ +10.54%
Token::is_minter +180 ❌ +10.54%
Lending::get_assets +80 ❌ +10.39%
TokenBlacklist::balance_of_public +185 ❌ +10.36%
Token::balance_of_public +185 ❌ +10.36%
CardGame::on_game_joined +445 ❌ +10.30%
Benchmarking::broadcast +172 ❌ +10.08%
StatefulTest::increment_public_value_no_init_check +176 ❌ +9.94%
AuthRegistry::set_reject_all +156 ❌ +9.92%
PriceFeed::get_price +166 ❌ +9.81%
StatefulTest::get_public_value +163 ❌ +9.79%
AvmTest::read_storage_map +162 ❌ +9.79%
Lending::get_asset +185 ❌ +9.77%
AuthRegistry::is_reject_all +163 ❌ +9.73%
PriceFeed::set_price +160 ❌ +9.68%
FeeJuice::balance_of_public +168 ❌ +9.59%
Parent::public_nested_static_call +342 ❌ +9.29%
AvmTest::debug_logging +108 ❌ +8.83%
Auth::get_authorized_delay +173 ❌ +8.46%
AvmTest::emit_unencrypted_log +194 ❌ +7.10%
AvmInitializerTest::public_dispatch +234 ❌ +6.88%
NFT::finalize_transfer_to_private +349 ❌ +6.67%
AvmTest::keccak_hash +164 ❌ +6.42%
Delegator::public_dispatch +119 ❌ +6.24%
Test::emit_unencrypted +95 ❌ +6.22%
Crowdfunding::_publish_donation_receipts +69 ❌ +5.72%
DelegatedOn::public_dispatch +67 ❌ +5.63%
AvmInitializerTest::constructor +148 ❌ +5.53%
FeeJuice::check_balance +111 ❌ +5.37%
AvmTest::poseidon2_hash +74 ❌ +4.96%
EasyPrivateVoting::end_vote +29 ❌ +4.72%
NFT::set_admin +29 ❌ +4.71%
Token::set_admin +29 ❌ +4.71%
Delegator::public_delegate_set_value +39 ❌ +4.64%
AvmTest::get_args_hash +66 ❌ +4.21%
StaticChild::pub_illegal_inc_value +28 ❌ +4.18%
AvmTest::u128_from_integer_overflow +29 ❌ +4.18%
Child::pub_inc_value +27 ❌ +4.15%
StaticChild::pub_inc_value +27 ❌ +4.15%
Child::pub_inc_value_internal +28 ❌ +4.15%
DocsExample::initialize_shared_immutable +31 ❌ +4.11%
DocsExample::initialize_public_immutable +31 ❌ +4.11%
DocsExample::get_shared_immutable_constrained_public_multiple +28 ❌ +4.07%
TokenBlacklist::total_supply +21 ❌ +3.58%
Token::total_supply +21 ❌ +3.58%
TokenBridge::_assert_token_is_same +17 ❌ +3.36%
AvmTest::read_storage_list +20 ❌ +3.33%
AvmTest::test_get_contract_instance +27 ❌ +3.32%
NFT::public_get_symbol +16 ❌ +3.27%
TokenBridge::get_token +16 ❌ +3.27%
Token::get_admin +16 ❌ +3.27%
NFT::get_admin +16 ❌ +3.23%
NFT::public_get_name +16 ❌ +3.23%
Token::public_get_symbol +16 ❌ +3.23%
Token::public_get_name +16 ❌ +3.23%
AvmInitializerTest::read_storage_immutable +15 ❌ +3.19%
Token::public_get_decimals +16 ❌ +3.14%
TokenBridge::get_portal_address_public +16 ❌ +3.04%
AvmTest::set_read_storage_single +16 ❌ +2.79%
AvmTest::variable_base_msm +8 ❌ +1.84%
NFT::_store_point_in_transient_storage +6 ❌ +1.78%
AvmTest::assert_calldata_copy +6 ❌ +1.43%
InclusionProofs::test_nullifier_inclusion_from_public +2 ❌ +1.41%
DocsExample::get_shared_immutable_constrained_public +7 ❌ +1.36%
AvmTest::read_storage_single +3 ❌ +0.69%
TokenBlacklist::_reduce_total_supply +5 ❌ +0.57%
Token::_reduce_total_supply +5 ❌ +0.57%
Child::pub_set_value +1 ❌ +0.32%
StaticChild::pub_set_value +1 ❌ +0.32%
Uniswap::swap_public +45 ❌ +0.31%
Lending::init -6 ✅ -0.22%
AvmTest::keccak_f1600 -2 ✅ -0.43%
AvmTest::test_get_contract_instance_raw -2 ✅ -0.54%
AvmTest::return_oracle -2 ✅ -0.61%
Uniswap::_assert_token_is_same -4 ✅ -0.89%
DocsExample::get_shared_immutable_constrained_public_indirect -5 ✅ -1.21%
AvmTest::pedersen_commit -5 ✅ -1.41%
AvmTest::to_radix_le -5 ✅ -2.13%
DocsExample::update_leader -7 ✅ -2.43%
AvmTest::set_storage_list -8 ✅ -3.19%
DelegatedOn::public_set_value -9 ✅ -3.80%
Router::_check_timestamp -48 ✅ -3.86%
AvmTest::set_storage_single -9 ✅ -3.90%
Router::_check_block_number -48 ✅ -3.91%
AvmTest::add_u128 -12 ✅ -5.97%
InclusionProofs::push_nullifier_public -8 ✅ -6.50%
Test::assert_public_global_vars -16 ✅ -6.58%
AvmTest::emit_nullifier_and_check -8 ✅ -6.78%
StaticChild::pub_get_value -13 ✅ -8.02%
AvmTest::l1_to_l2_msg_exists -9 ✅ -8.18%
AvmTest::note_hash_exists -9 ✅ -8.18%
AvmTest::nullifier_exists -9 ✅ -8.26%
Child::public_dispatch -461 ✅ -8.56%
AvmTest::assert_nullifier_exists -10 ✅ -8.77%
Child::pub_get_value -14 ✅ -10.22%
Lending::deposit_public -228 ✅ -13.52%
AuthWitTest::public_dispatch -280 ✅ -13.77%
AvmTest::assert_same -17 ✅ -14.41%
StaticParent::public_nested_static_call -182 ✅ -14.48%
ImportTest::public_dispatch -245 ✅ -15.06%
FPC::pay_refund -248 ✅ -15.26%
FPC::prepare_fee -183 ✅ -15.44%
Lending::borrow_public -187 ✅ -16.76%
Lending::withdraw_public -187 ✅ -16.76%
Test::is_time_equal -21 ✅ -17.65%
AvmTest::set_opcode_really_big_field -22 ✅ -17.89%
AvmTest::set_opcode_big_field -22 ✅ -17.89%
AvmTest::send_l2_to_l1_msg -18 ✅ -18.37%
Test::create_l2_to_l1_message_arbitrary_recipient_public -18 ✅ -18.37%
Lending::repay_public -292 ✅ -18.48%
AvmTest::assert_timestamp -21 ✅ -18.58%
AvmTest::nullifier_collision -18 ✅ -19.15%
AvmTest::modulo2 -22 ✅ -19.47%
AvmTest::add_args_return -21 ✅ -19.63%
FPC::pay_refund_with_shielded_rebate -309 ✅ -19.80%
Test::dummy_public_call -21 ✅ -20.00%
AvmTest::set_opcode_small_field -22 ✅ -20.56%
DocsExample::spend_public_authwit -22 ✅ -21.78%
AvmTest::new_note_hash -20 ✅ -22.22%
AvmTest::set_opcode_u64 -22 ✅ -22.22%
AvmTest::new_nullifier -20 ✅ -22.22%
Test::emit_nullifier_public -20 ✅ -22.22%
AvmTest::set_opcode_u32 -22 ✅ -23.16%
AvmTest::get_fee_per_da_gas -22 ✅ -24.18%
AvmTest::set_opcode_u8 -22 ✅ -24.18%
AvmTest::get_timestamp -22 ✅ -24.18%
AvmTest::get_block_number -22 ✅ -24.18%
AvmTest::get_l2_gas_left -22 ✅ -24.18%
AvmTest::get_storage_address -22 ✅ -24.18%
AvmTest::get_sender -22 ✅ -24.18%
AvmTest::get_da_gas_left -22 ✅ -24.18%
AvmTest::get_fee_per_l2_gas -22 ✅ -24.18%
AvmTest::get_address -22 ✅ -24.18%
AvmTest::get_transaction_fee -22 ✅ -24.18%
AvmTest::get_chain_id -22 ✅ -24.18%
AvmTest::get_version -22 ✅ -24.18%
Child::set_value_twice_with_nested_last -300 ✅ -34.48%
Child::set_value_twice_with_nested_first -300 ✅ -34.48%
TokenBridge::_call_mint_on_token -408 ✅ -34.61%
Parent::public_static_call -404 ✅ -43.49%
StaticParent::public_static_call -404 ✅ -43.49%
AvmTest::assertion_failure -71 ✅ -45.81%
Parent::pub_entry_point -317 ✅ -46.28%
StaticParent::public_call -317 ✅ -46.28%
StaticParent::public_get_value_from_child -317 ✅ -46.89%
Child::set_value_with_two_nested_calls -592 ✅ -47.32%
AvmTest::create_different_nullifier_in_nested_call -325 ✅ -48.87%
AuthWitTest::consume_public -416 ✅ -49.70%
AvmTest::check_selector -87 ✅ -49.71%
AvmTest::create_same_nullifier_in_nested_call -326 ✅ -49.77%
ImportTest::pub_call_public_fn -328 ✅ -50.46%
AvmTest::nested_static_call_to_set_storage -328 ✅ -50.54%
Parent::pub_entry_point_twice -593 ✅ -52.25%
AvmTest::nested_call_to_add_with_gas -431 ✅ -54.28%
AvmTest::nested_call_to_add -445 ✅ -54.33%
AvmTest::nested_static_call_to_add -445 ✅ -54.33%
AvmTest::get_function_selector -92 ✅ -57.14%
AvmTest::elliptic_curve_add_and_double -439 ✅ -70.92%
Full diff report 👇
Program Bytecode size in bytes (+/-) %
TokenBlacklist::public_dispatch 130,120 (+106,091) +441.51%
AuthRegistry::public_dispatch 23,251 (+15,594) +203.66%
Lending::public_dispatch 75,524 (+50,140) +197.53%
Auth::public_dispatch 29,880 (+19,621) +191.26%
AuthRegistry::consume 8,258 (+5,409) +189.86%
TokenBlacklist::transfer_public 15,095 (+9,140) +153.48%
Lending::update_accumulator 12,821 (+7,706) +150.65%
Token::public_dispatch 65,223 (+38,318) +142.42%
TokenBlacklist::mint_public 9,611 (+5,497) +133.62%
AvmTest::add_storage_map 4,212 (+2,242) +113.81%
TokenBlacklist::update_roles 14,608 (+7,658) +110.19%
NFT::mint 5,948 (+3,028) +103.70%
Lending::_borrow 14,838 (+7,517) +102.68%
Token::transfer_public 9,249 (+4,667) +101.86%
TokenBlacklist::constructor 14,722 (+7,092) +92.95%
CardGame::public_dispatch 28,156 (+13,497) +92.07%
Test::public_dispatch 32,850 (+15,622) +90.68%
TokenBlacklist::shield 11,367 (+5,349) +88.88%
NFT::public_dispatch 39,211 (+18,256) +87.12%
Auth::set_authorized 10,114 (+4,685) +86.30%
Auth::set_authorized_delay 9,918 (+4,569) +85.42%
Lending::_repay 9,362 (+4,254) +83.28%
TokenBlacklist::burn_public 9,798 (+4,245) +76.45%
FeeJuice::public_dispatch 9,875 (+4,271) +76.21%
Lending::_withdraw 12,754 (+5,377) +72.89%
Token::shield 8,397 (+3,462) +70.15%
Token::mint_public 5,256 (+2,158) +69.66%
AuthRegistry::set_authorized 2,927 (+1,201) +69.58%
AuthRegistry::_set_authorized 2,954 (+1,202) +68.61%
AvmTest::public_dispatch 89,662 (+36,473) +68.57%
AvmTest::set_storage_map 2,804 (+1,126) +67.10%
AuthRegistry::is_consumable 3,041 (+1,208) +65.90%
StatefulTest::public_dispatch 12,206 (+4,839) +65.68%
Lending::get_position 7,620 (+2,983) +64.33%
TokenBridge::public_dispatch 31,443 (+12,111) +62.65%
AppSubscription::constructor 6,021 (+2,262) +60.18%
AppSubscription::public_dispatch 7,990 (+2,981) +59.51%
Test::consume_mint_public_message 13,411 (+4,858) +56.80%
Uniswap::_approve_bridge_and_exit_input_asset_to_L1 8,871 (+3,197) +56.34%
TokenBlacklist::mint_private 5,866 (+2,105) +55.97%
EasyPrivateVoting::public_dispatch 9,177 (+3,280) +55.62%
EasyPrivateVoting::add_to_tally_public 3,390 (+1,206) +55.22%
NFT::constructor 7,299 (+2,540) +53.37%
Token::constructor 7,788 (+2,686) +52.65%
Token::burn_public 6,828 (+2,353) +52.58%
FeeJuice::_increase_public_balance 3,342 (+1,101) +49.13%
Token::mint_private 4,387 (+1,429) +48.31%
TokenBridge::claim_public 14,557 (+4,658) +47.06%
NFT::transfer_in_public 5,071 (+1,540) +43.61%
Benchmarking::public_dispatch 6,734 (+2,011) +42.58%
Router::public_dispatch 3,847 (+1,128) +41.49%
Crowdfunding::init 5,079 (+1,467) +40.61%
Spam::public_spam 3,396 (+974) +40.21%
PriceFeed::public_dispatch 4,935 (+1,407) +39.88%
Uniswap::public_dispatch 32,019 (+8,842) +38.15%
TokenBlacklist::get_roles 3,353 (+923) +37.98%
TokenBlacklist::_increase_public_balance 3,387 (+927) +37.68%
Token::_increase_public_balance 3,387 (+927) +37.68%
NFT::owner_of 3,284 (+883) +36.78%
InclusionProofs::public_dispatch 5,630 (+1,508) +36.58%
Spam::public_dispatch 4,562 (+1,215) +36.30%
InclusionProofs::constructor 3,715 (+989) +36.28%
Claim::constructor 4,505 (+1,188) +35.82%
Crowdfunding::public_dispatch 8,163 (+2,133) +35.37%
Claim::public_dispatch 5,655 (+1,424) +33.66%
Test::consume_message_from_arbitrary_sender_public 8,656 (+2,165) +33.35%
StaticChild::public_dispatch 3,679 (+916) +33.15%
AvmTest::bulk_testing 31,458 (+7,754) +32.71%
EasyPrivateVoting::constructor 4,390 (+1,070) +32.23%
FPC::constructor 4,113 (+956) +30.28%
Uniswap::constructor 4,113 (+956) +30.28%
Auth::constructor 4,135 (+958) +30.15%
PrivateFPC::constructor 4,044 (+890) +28.22%
PrivateFPC::public_dispatch 5,194 (+1,131) +27.84%
TokenBridge::constructor 4,182 (+886) +26.88%
Benchmarking::increment_balance 3,694 (+782) +26.85%
TestLog::emit_unencrypted_events 2,130 (+450) +26.79%
Parent::public_dispatch 10,145 (+2,124) +26.48%
FPC::public_dispatch 10,931 (+2,164) +24.68%
StaticParent::public_dispatch 6,921 (+1,309) +23.33%
Token::complete_refund 3,356 (+627) +22.98%
AvmTest::sha256_hash 3,565 (+636) +21.71%
StatefulTest::public_constructor 4,225 (+747) +21.48%
CardGame::start_game 7,285 (+1,199) +19.70%
TestLog::public_dispatch 3,455 (+502) +17.00%
CardGame::on_card_played 5,908 (+838) +16.53%
Test::create_l2_to_l1_message_public 2,330 (+330) +16.50%
DocsExample::public_dispatch 5,782 (+779) +15.57%
AvmTest::u128_addition_overflow 1,357 (+182) +15.49%
TokenBridge::exit_to_l1_public 7,761 (+1,023) +15.18%
Auth::get_scheduled_authorized 1,893 (+243) +14.73%
Auth::get_authorized 1,994 (+252) +14.47%
AvmTest::pedersen_hash_with_index 3,401 (+375) +12.39%
AvmTest::pedersen_hash 3,401 (+375) +12.39%
Lending::_deposit 2,479 (+270) +12.22%
CardGame::on_cards_claimed 7,475 (+799) +11.97%
FeeJuice::set_portal 1,017 (+108) +11.88%
Token::assert_minter_and_mint 2,458 (+243) +10.97%
NFT::_finish_transfer_to_public 1,789 (+174) +10.77%
StatefulTest::increment_public_value 1,992 (+193) +10.73%
NFT::set_minter 2,024 (+193) +10.54%
Token::set_minter 2,024 (+193) +10.54%
NFT::is_minter 1,888 (+180) +10.54%
Token::is_minter 1,888 (+180) +10.54%
Lending::get_assets 850 (+80) +10.39%
TokenBlacklist::balance_of_public 1,970 (+185) +10.36%
Token::balance_of_public 1,970 (+185) +10.36%
CardGame::on_game_joined 4,767 (+445) +10.30%
Benchmarking::broadcast 1,878 (+172) +10.08%
StatefulTest::increment_public_value_no_init_check 1,947 (+176) +9.94%
AuthRegistry::set_reject_all 1,729 (+156) +9.92%
PriceFeed::get_price 1,859 (+166) +9.81%
StatefulTest::get_public_value 1,828 (+163) +9.79%
AvmTest::read_storage_map 1,817 (+162) +9.79%
Lending::get_asset 2,078 (+185) +9.77%
AuthRegistry::is_reject_all 1,838 (+163) +9.73%
PriceFeed::set_price 1,813 (+160) +9.68%
FeeJuice::balance_of_public 1,920 (+168) +9.59%
Parent::public_nested_static_call 4,024 (+342) +9.29%
AvmTest::debug_logging 1,331 (+108) +8.83%
Auth::get_authorized_delay 2,219 (+173) +8.46%
AvmTest::emit_unencrypted_log 2,927 (+194) +7.10%
AvmInitializerTest::public_dispatch 3,636 (+234) +6.88%
NFT::finalize_transfer_to_private 5,585 (+349) +6.67%
AvmTest::keccak_hash 2,719 (+164) +6.42%
Delegator::public_dispatch 2,025 (+119) +6.24%
Test::emit_unencrypted 1,623 (+95) +6.22%
Crowdfunding::_publish_donation_receipts 1,276 (+69) +5.72%
DelegatedOn::public_dispatch 1,256 (+67) +5.63%
AvmInitializerTest::constructor 2,824 (+148) +5.53%
FeeJuice::check_balance 2,179 (+111) +5.37%
AvmTest::poseidon2_hash 1,566 (+74) +4.96%
EasyPrivateVoting::end_vote 644 (+29) +4.72%
NFT::set_admin 645 (+29) +4.71%
Token::set_admin 645 (+29) +4.71%
Delegator::public_delegate_set_value 879 (+39) +4.64%
AvmTest::get_args_hash 1,632 (+66) +4.21%
StaticChild::pub_illegal_inc_value 698 (+28) +4.18%
AvmTest::u128_from_integer_overflow 723 (+29) +4.18%
Child::pub_inc_value 677 (+27) +4.15%
StaticChild::pub_inc_value 677 (+27) +4.15%
Child::pub_inc_value_internal 703 (+28) +4.15%
DocsExample::initialize_shared_immutable 786 (+31) +4.11%
DocsExample::initialize_public_immutable 786 (+31) +4.11%
DocsExample::get_shared_immutable_constrained_public_multiple 716 (+28) +4.07%
TokenBlacklist::total_supply 608 (+21) +3.58%
Token::total_supply 608 (+21) +3.58%
TokenBridge::_assert_token_is_same 523 (+17) +3.36%
AvmTest::read_storage_list 621 (+20) +3.33%
AvmTest::test_get_contract_instance 841 (+27) +3.32%
NFT::public_get_symbol 506 (+16) +3.27%
TokenBridge::get_token 506 (+16) +3.27%
Token::get_admin 506 (+16) +3.27%
NFT::get_admin 511 (+16) +3.23%
NFT::public_get_name 511 (+16) +3.23%
Token::public_get_symbol 511 (+16) +3.23%
Token::public_get_name 511 (+16) +3.23%
AvmInitializerTest::read_storage_immutable 485 (+15) +3.19%
Token::public_get_decimals 526 (+16) +3.14%
TokenBridge::get_portal_address_public 543 (+16) +3.04%
AvmTest::set_read_storage_single 589 (+16) +2.79%
AvmTest::variable_base_msm 442 (+8) +1.84%
NFT::_store_point_in_transient_storage 343 (+6) +1.78%
AvmTest::assert_calldata_copy 427 (+6) +1.43%
InclusionProofs::test_nullifier_inclusion_from_public 144 (+2) +1.41%
DocsExample::get_shared_immutable_constrained_public 522 (+7) +1.36%
AvmTest::read_storage_single 440 (+3) +0.69%
TokenBlacklist::_reduce_total_supply 882 (+5) +0.57%
Token::_reduce_total_supply 882 (+5) +0.57%
Child::pub_set_value 314 (+1) +0.32%
StaticChild::pub_set_value 314 (+1) +0.32%
Uniswap::swap_public 14,342 (+45) +0.31%
Lending::init 2,768 (-6) -0.22%
AvmTest::keccak_f1600 465 (-2) -0.43%
AvmTest::test_get_contract_instance_raw 365 (-2) -0.54%
AvmTest::return_oracle 328 (-2) -0.61%
Uniswap::_assert_token_is_same 444 (-4) -0.89%
DocsExample::get_shared_immutable_constrained_public_indirect 407 (-5) -1.21%
AvmTest::pedersen_commit 350 (-5) -1.41%
AvmTest::to_radix_le 230 (-5) -2.13%
DocsExample::update_leader 281 (-7) -2.43%
AvmTest::set_storage_list 243 (-8) -3.19%
DelegatedOn::public_set_value 228 (-9) -3.80%
Router::_check_timestamp 1,197 (-48) -3.86%
AvmTest::set_storage_single 222 (-9) -3.90%
Router::_check_block_number 1,180 (-48) -3.91%
AvmTest::add_u128 189 (-12) -5.97%
InclusionProofs::push_nullifier_public 115 (-8) -6.50%
Test::assert_public_global_vars 227 (-16) -6.58%
AvmTest::emit_nullifier_and_check 110 (-8) -6.78%
StaticChild::pub_get_value 149 (-13) -8.02%
AvmTest::l1_to_l2_msg_exists 101 (-9) -8.18%
AvmTest::note_hash_exists 101 (-9) -8.18%
AvmTest::nullifier_exists 100 (-9) -8.26%
Child::public_dispatch 4,922 (-461) -8.56%
AvmTest::assert_nullifier_exists 104 (-10) -8.77%
Child::pub_get_value 123 (-14) -10.22%
Lending::deposit_public 1,458 (-228) -13.52%
AuthWitTest::public_dispatch 1,754 (-280) -13.77%
AvmTest::assert_same 101 (-17) -14.41%
StaticParent::public_nested_static_call 1,075 (-182) -14.48%
ImportTest::public_dispatch 1,382 (-245) -15.06%
FPC::pay_refund 1,377 (-248) -15.26%
FPC::prepare_fee 1,002 (-183) -15.44%
Lending::borrow_public 929 (-187) -16.76%
Lending::withdraw_public 929 (-187) -16.76%
Test::is_time_equal 98 (-21) -17.65%
AvmTest::set_opcode_really_big_field 101 (-22) -17.89%
AvmTest::set_opcode_big_field 101 (-22) -17.89%
AvmTest::send_l2_to_l1_msg 80 (-18) -18.37%
Test::create_l2_to_l1_message_arbitrary_recipient_public 80 (-18) -18.37%
Lending::repay_public 1,288 (-292) -18.48%
AvmTest::assert_timestamp 92 (-21) -18.58%
AvmTest::nullifier_collision 76 (-18) -19.15%
AvmTest::modulo2 91 (-22) -19.47%
AvmTest::add_args_return 86 (-21) -19.63%
FPC::pay_refund_with_shielded_rebate 1,252 (-309) -19.80%
Test::dummy_public_call 84 (-21) -20.00%
AvmTest::set_opcode_small_field 85 (-22) -20.56%
DocsExample::spend_public_authwit 79 (-22) -21.78%
AvmTest::new_note_hash 70 (-20) -22.22%
AvmTest::set_opcode_u64 77 (-22) -22.22%
AvmTest::new_nullifier 70 (-20) -22.22%
Test::emit_nullifier_public 70 (-20) -22.22%
AvmTest::set_opcode_u32 73 (-22) -23.16%
AvmTest::get_fee_per_da_gas 69 (-22) -24.18%
AvmTest::set_opcode_u8 69 (-22) -24.18%
AvmTest::get_timestamp 69 (-22) -24.18%
AvmTest::get_block_number 69 (-22) -24.18%
AvmTest::get_l2_gas_left 69 (-22) -24.18%
AvmTest::get_storage_address 69 (-22) -24.18%
AvmTest::get_sender 69 (-22) -24.18%
AvmTest::get_da_gas_left 69 (-22) -24.18%
AvmTest::get_fee_per_l2_gas 69 (-22) -24.18%
AvmTest::get_address 69 (-22) -24.18%
AvmTest::get_transaction_fee 69 (-22) -24.18%
AvmTest::get_chain_id 69 (-22) -24.18%
AvmTest::get_version 69 (-22) -24.18%
Child::set_value_twice_with_nested_last 570 (-300) -34.48%
Child::set_value_twice_with_nested_first 570 (-300) -34.48%
TokenBridge::_call_mint_on_token 771 (-408) -34.61%
Parent::public_static_call 525 (-404) -43.49%
StaticParent::public_static_call 525 (-404) -43.49%
AvmTest::assertion_failure 84 (-71) -45.81%
Parent::pub_entry_point 368 (-317) -46.28%
StaticParent::public_call 368 (-317) -46.28%
StaticParent::public_get_value_from_child 359 (-317) -46.89%
Child::set_value_with_two_nested_calls 659 (-592) -47.32%
AvmTest::create_different_nullifier_in_nested_call 340 (-325) -48.87%
AuthWitTest::consume_public 421 (-416) -49.70%
AvmTest::check_selector 88 (-87) -49.71%
AvmTest::create_same_nullifier_in_nested_call 329 (-326) -49.77%
ImportTest::pub_call_public_fn 322 (-328) -50.46%
AvmTest::nested_static_call_to_set_storage 321 (-328) -50.54%
Parent::pub_entry_point_twice 542 (-593) -52.25%
AvmTest::nested_call_to_add_with_gas 363 (-431) -54.28%
AvmTest::nested_call_to_add 374 (-445) -54.33%
AvmTest::nested_static_call_to_add 374 (-445) -54.33%
AvmTest::get_function_selector 69 (-92) -57.14%
AvmTest::elliptic_curve_add_and_double 180 (-439) -70.92%

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 15, 2024 •
edited
Loading

Changes to circuit sizes

Generated at commit: 63bef728ca21022ea0152ad118c26ae0dfa0b99d, compared to commit: 5a3a8ccd0286a16b93c95a1de21676250926456a

🧾 Summary (100% most significant diffs)

Program ACIR opcodes (+/-) % Circuit size (+/-) %
public_kernel_merge_simulated 0 ➖ 0.00% +3,115 ❌ +19468.75%
public_kernel_inner_simulated 0 ➖ 0.00% +2,460 ❌ +15375.00%
private_kernel_tail_to_public_simulated 0 ➖ 0.00% +3,113 ❌ +14823.81%
private_kernel_init_simulated 0 ➖ 0.00% +1,956 ❌ +9314.29%
private_kernel_inner_simulated 0 ➖ 0.00% +1,956 ❌ +9314.29%
private_kernel_reset_simulated 0 ➖ 0.00% +1,956 ❌ +9314.29%
private_kernel_reset_simulated_4_4_4_4_4_4_4_4_1 0 ➖ 0.00% +1,956 ❌ +9314.29%
private_kernel_empty_simulated 0 ➖ 0.00% +655 ❌ +4093.75%
public_kernel_tail_simulated 0 ➖ 0.00% +652 ❌ +4075.00%
private_kernel_tail_simulated 0 ➖ 0.00% +650 ❌ +3095.24%
rollup_base_simulated 0 ➖ 0.00% +18 ❌ +112.50%
parity_base -3,282 ✅ -61.11% +21,115 ❌ +65.39%
private_kernel_tail +35 ❌ +0.74% +2,028 ❌ +21.25%
private_kernel_tail_to_public -59 ✅ -0.20% +4,886 ❌ +12.20%
private_kernel_inner -152 ✅ -0.34% +3,954 ❌ +7.48%
rollup_block_root_empty +31 ❌ +50.00% +121 ❌ +4.23%
rollup_block_merge +11,571 ❌ +158.75% +52,309 ❌ +2.75%
rollup_root +11,571 ❌ +159.10% +52,291 ❌ +2.75%
public_kernel_merge -106 ✅ -0.20% +13,671 ❌ +1.24%
parity_root -3,310 ✅ -60.99% +39,916 ❌ +1.06%
rollup_block_root -2,286 ✅ -53.76% +29,999 ❌ +1.06%
rollup_merge -2,312 ✅ -60.92% +19,206 ❌ +1.01%
private_kernel_reset -57 ✅ -0.06% +3,756 ❌ +0.80%
private_kernel_reset_4_4_4_4_4_4_4_4_1 -57 ✅ -0.16% +551 ❌ +0.73%
public_kernel_tail +739 ❌ +0.29% +10,995 ❌ +0.48%
public_kernel_inner -3 ✅ -0.00% +1,711 ❌ +0.33%
private_kernel_init -102 ✅ -0.41% -121 ✅ -0.37%
rollup_base -60,205 ✅ -12.46% -40,989 ✅ -1.22%
empty_nested 0 ➖ +∞% -8 ✅ -50.00%
empty_nested_simulated 0 ➖ 0.00% -8 ✅ -50.00%
private_kernel_empty -1 ✅ -0.15% -935,833 ✅ -99.56%
Full diff report 👇
Program ACIR opcodes (+/-) % Circuit size (+/-) %
public_kernel_merge_simulated 1 (0) 0.00% 3,131 (+3,115) +19468.75%
public_kernel_inner_simulated 1 (0) 0.00% 2,476 (+2,460) +15375.00%
private_kernel_tail_to_public_simulated 1 (0) 0.00% 3,134 (+3,113) +14823.81%
private_kernel_init_simulated 1 (0) 0.00% 1,977 (+1,956) +9314.29%
private_kernel_inner_simulated 1 (0) 0.00% 1,977 (+1,956) +9314.29%
private_kernel_reset_simulated 1 (0) 0.00% 1,977 (+1,956) +9314.29%
private_kernel_reset_simulated_4_4_4_4_4_4_4_4_1 1 (0) 0.00% 1,977 (+1,956) +9314.29%
private_kernel_empty_simulated 1 (0) 0.00% 671 (+655) +4093.75%
public_kernel_tail_simulated 1 (0) 0.00% 668 (+652) +4075.00%
private_kernel_tail_simulated 1 (0) 0.00% 671 (+650) +3095.24%
rollup_base_simulated 1 (0) 0.00% 34 (+18) +112.50%
parity_base 2,089 (-3,282) -61.11% 53,408 (+21,115) +65.39%
private_kernel_tail 4,745 (+35) +0.74% 11,573 (+2,028) +21.25%
private_kernel_tail_to_public 29,831 (-59) -0.20% 44,919 (+4,886) +12.20%
private_kernel_inner 43,951 (-152) -0.34% 56,831 (+3,954) +7.48%
rollup_block_root_empty 93 (+31) +50.00% 2,980 (+121) +4.23%
rollup_block_merge 18,860 (+11,571) +158.75% 1,952,775 (+52,309) +2.75%
rollup_root 18,844 (+11,571) +159.10% 1,952,743 (+52,291) +2.75%
public_kernel_merge 53,488 (-106) -0.20% 1,117,793 (+13,671) +1.24%
parity_root 2,117 (-3,310) -60.99% 3,816,888 (+39,916) +1.06%
rollup_block_root 1,966 (-2,286) -53.76% 2,868,779 (+29,999) +1.06%
rollup_merge 1,483 (-2,312) -60.92% 1,916,503 (+19,206) +1.01%
private_kernel_reset 91,935 (-57) -0.06% 472,006 (+3,756) +0.80%
private_kernel_reset_4_4_4_4_4_4_4_4_1 34,899 (-57) -0.16% 75,549 (+551) +0.73%
public_kernel_tail 259,172 (+739) +0.29% 2,281,716 (+10,995) +0.48%
public_kernel_inner 268,756 (-3) -0.00% 518,289 (+1,711) +0.33%
private_kernel_init 24,901 (-102) -0.41% 32,162 (-121) -0.37%
rollup_base 423,026 (-60,205) -12.46% 3,315,266 (-40,989) -1.22%
empty_nested 0 (0) +∞% 8 (-8) -50.00%
empty_nested_simulated 1 (0) 0.00% 8 (-8) -50.00%
private_kernel_empty 670 (-1) -0.15% 4,129 (-935,833) -99.56%

@TomAFrench TomAFrench closed this Oct 15, 2024
@TomAFrench TomAFrench deleted the sync-noir branch October 15, 2024 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TomAFrench TomAFrench TomAFrench approved these changes

@fcarreiro fcarreiro Awaiting requested review from fcarreiro fcarreiro is a code owner

@dbanks12 dbanks12 Awaiting requested review from dbanks12 dbanks12 is a code owner

@jeanmon jeanmon Awaiting requested review from jeanmon jeanmon is a code owner

@IlyasRidhuan IlyasRidhuan Awaiting requested review from IlyasRidhuan IlyasRidhuan is a code owner

@Maddiaa0 Maddiaa0 Awaiting requested review from Maddiaa0 Maddiaa0 is a code owner

@vezenovm vezenovm Awaiting requested review from vezenovm vezenovm is a code owner

@guipublic guipublic Awaiting requested review from guipublic guipublic is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AztecBot @TomAFrench