Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: blobs. #9302
base: master
Are you sure you want to change the base?
feat: blobs. #9302
Changes from 11 commits
d2544a9
9cefc9a
df93cf5
c5539eb
5e92023
1d17855
aff5e35
dfe722b
bc0678c
ad090f6
bf98bbc
2cd7570
8a8dcab
cc01696
6f92b1f
233d3fd
7c1749d
247a49d
8f3d10f
20674cf
38725f8
77dcf8e
580b1b2
2166780
99ac96e
43bb5f0
88733fe
37f7af4
9bb2c21
c667c50
3a7a997
225ba00
27d839e
f241744
9c4c4da
6cbab7e
deeb044
afe79e0
38796a0
e80ff6e
4c2477f
5dbd06c
899eea0
a662fe4
5b80e50
079aef8
23092c6
ad7bb09
fd6b875
a367e6f
5e506ce
a418c58
c06c2ef
46d2b3d
3969035
f4267c5
0e9b2c8
96157d0
fcbc6ce
bcf452e
9a67624
76ccac1
526b4c6
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ TMNT team: here we need to check the data has been published. I could add the EVM's blobHash to the block header (we can calculate it in ts in advance) and uncomment the check?
However it could be doable without adding more fields to the header by having some
isAvailable
mapping filled once_validateBlob
is called. Not sure which is preferable based on the team's priorities!There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The linter should be screaming at you down here as function and parameter names are not following the rules.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's not - could you please advise what best to do here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be a versioning, but for internal or private functions use
_
as prefix for the function name, and for parameters generally use_
as prefix.