-
Notifications
You must be signed in to change notification settings - Fork 310
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: use address book in recipient tag calculation #9618
Merged
sklppy88
merged 1 commit into
master
from
ek/feat/new-note-tagging-scheme-implementation/use-address-book-in-recipient-tag-calculation
Nov 1, 2024
Merged
feat: use address book in recipient tag calculation #9618
sklppy88
merged 1 commit into
master
from
ek/feat/new-note-tagging-scheme-implementation/use-address-book-in-recipient-tag-calculation
Nov 1, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 31, 2024
75da85e
to
b8481ab
Compare
bb6a3a1
to
4fb64a7
Compare
b8481ab
to
e45714a
Compare
4fb64a7
to
90b9f43
Compare
e45714a
to
8ada3c6
Compare
Thunkar
approved these changes
Oct 31, 2024
8ada3c6
to
d350085
Compare
f5f9542
to
e636349
Compare
d350085
to
f6e4e0f
Compare
Base automatically changed from
ek/feat/new-note-tagging-scheme-implementation/add-increment-secret-oracles
to
master
October 31, 2024 15:29
f6e4e0f
to
7c33d2a
Compare
7c33d2a
to
9ffbb33
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A simple refactor to use our address book instead of the complete address db (which was used before because we were using registerRecipient as a standin for the address book) when we calculate tags for getting our incoming notes from the node.