refactor: enqueued calls processor -> public tx simulator #9919
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbanks12
force-pushed
the
db/refactor-enqueued-calls-processor
branch
from
de18982 to
1ff73fb
Compare
dbanks12
requested review from
jeanmon,
IlyasRidhuan and
Maddiaa0
as code owners
This stack of pull requests is managed by Graphite. Learn more about stacking. |
dbanks12
force-pushed
the
db/refactor-enqueued-calls-processor
branch
from
1ff73fb to
eeba295
Compare
dbanks12
force-pushed
the
db/refactor-enqueued-calls-processor
branch
4 times, most recently
from
405bc84 to
065a139
Compare
dbanks12
force-pushed
the
db/refactor-enqueued-calls-processor
branch
from
065a139 to
889d1c9
Compare
dbanks12
changed the title
dbanks12
commented
Nov 15, 2024
dbanks12
commented
Nov 15, 2024
dbanks12
commented
Nov 15, 2024
dbanks12
commented
Nov 15, 2024
dbanks12
commented
Nov 15, 2024
dbanks12
commented
Nov 15, 2024
Comment on lines
+177
to
+178
| const callRequests = context.getCallRequestsForCurrentPhase(); | ||
| const executionRequests = context.getExecutionRequestsForCurrentPhase(); |
There was a problem hiding this comment.
If all we need from PublicExecutionRequests is args, we probably can just work with PublicCallRequests & args instead of PublicCallRequests & PublicExecutionRequests
dbanks12
commented
Nov 15, 2024
dbanks12
commented
Nov 15, 2024
fcarreiro
reviewed
Nov 15, 2024
There was a problem hiding this comment.
Maybe some docstrings on the classes?
| import { PublicSideEffectTrace } from './side_effect_trace.js'; | ||
| import { getCallRequestsByPhase, getExecutionRequestsByPhase, getPublicKernelCircuitPublicInputs } from './utils.js'; | ||
|
|
||
| class PhaseStateManager { |
There was a problem hiding this comment.
Why do we need this class?
LeilaWang
reviewed
Nov 15, 2024
fcarreiro
approved these changes
Nov 15, 2024
TomAFrench
added a commit
that referenced
this pull request
Nov 18, 2024
* master: (281 commits) fix: don't take down runners with faulty runner check (#10019) feat(docs): add transaction profiler docs (#9932) chore: hotfix runner wait (#10018) refactor: remove EnqueuedCallSimulator (#10015) refactor: stop calling public kernels (#9971) git subrepo push --branch=master noir-projects/aztec-nr git_subrepo.sh: Fix parent in .gitrepo file. [skip ci] chore: replace relative paths to noir-protocol-circuits git subrepo push --branch=master barretenberg chore: drop info to verbose in sequencer hot loop (#9983) refactor: Trace structure is an object (#10003) refactor: enqueued calls processor -> public tx simulator (#9919) chore: World state tech debt cleanup 1 (#9561) chore(ci): run noir tests in parallel to building e2e tests (#9977) Revert "chore: lower throughput of ebs disks" (#9996) feat: new proving broker implementation (#9400) chore: replace `to_radix` directive with brillig (#9970) chore: disable failing 48validator kind test (#9920) test: prove one epoch in kind (#9886) fix: formatting (#9979) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Peek at the other PRs in this stack to see how things will simplify further!
I am open to all feedback when it comes to the refactor of EnqueuedCallsProcessor, this new PublicTxContext, state forking, etc.