Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: pull out reference changes from sync PR #9967

Merged
merged 1 commit into from
Nov 14, 2024

Conversation

TomAFrench
Copy link
Member

This PR pulls out Jake's changes to how we handle references.

Copy link
Contributor

Changes to public function bytecode sizes

Generated at commit: ba953e554d1ffb4f87ba0e8c1c96a7183f2f66d6, compared to commit: 188f60a34ee890fe7886f9582b91fb8123d0a596

🧾 Summary (100% most significant diffs)

Program Bytecode size in bytes (+/-) %
FPC::public_dispatch +84 ❌ +1.00%
InclusionProofs::public_dispatch +36 ❌ +0.86%
StaticChild::public_dispatch +26 ❌ +0.82%
AuthWitTest::public_dispatch +13 ❌ +0.66%
AuthRegistry::public_dispatch +49 ❌ +0.58%
Crowdfunding::public_dispatch +36 ❌ +0.58%
StaticParent::public_dispatch +39 ❌ +0.53%
Router::public_dispatch +13 ❌ +0.50%
AppSubscription::public_dispatch +23 ❌ +0.46%
StatefulTest::public_dispatch +36 ❌ +0.44%
Test::public_dispatch +88 ❌ +0.43%
DocsExample::public_dispatch +26 ❌ +0.43%
Child::public_dispatch +26 ❌ +0.43%
AvmInitializerTest::constructor +10 ❌ +0.39%
InclusionProofs::constructor +10 ❌ +0.38%
EasyPrivateVoting::public_dispatch +23 ❌ +0.38%
Spam::public_dispatch +14 ❌ +0.37%
TokenBlacklist::get_roles +10 ❌ +0.36%
PriceFeed::public_dispatch +14 ❌ +0.34%
Claim::public_dispatch +14 ❌ +0.33%
Uniswap::constructor +10 ❌ +0.33%
Auth::constructor +10 ❌ +0.32%
AuthRegistry::consume +10 ❌ +0.31%
EasyPrivateVoting::constructor +10 ❌ +0.31%
AvmInitializerTest::public_dispatch +10 ❌ +0.29%
NFT::public_dispatch +75 ❌ +0.28%
Crowdfunding::init +10 ❌ +0.28%
AppSubscription::constructor +10 ❌ +0.27%
NFT::transfer_in_public +10 ❌ +0.27%
StatefulTest::public_constructor +10 ❌ +0.26%
Uniswap::public_dispatch +62 ❌ +0.25%
TokenBlacklist::public_dispatch +62 ❌ +0.25%
TokenBlacklist::mint_private +10 ❌ +0.23%
FeeJuice::public_dispatch +14 ❌ +0.22%
TokenBlacklist::mint_public +10 ❌ +0.22%
Token::burn_public +10 ❌ +0.21%
Auth::public_dispatch +23 ❌ +0.21%
NFT::constructor +10 ❌ +0.21%
Token::transfer_in_public +10 ❌ +0.21%
Token::constructor +10 ❌ +0.19%
AvmTest::public_dispatch +114 ❌ +0.19%
TokenBlacklist::burn_public +10 ❌ +0.17%
Auth::set_authorized_delay +10 ❌ +0.17%
Auth::set_authorized +10 ❌ +0.17%
Parent::public_dispatch +14 ❌ +0.16%
TokenBridge::public_dispatch +36 ❌ +0.16%
TokenBlacklist::transfer_public +10 ❌ +0.16%
TokenBlacklist::shield +10 ❌ +0.16%
Uniswap::_approve_bridge_and_exit_input_asset_to_L1 +10 ❌ +0.15%
Lending::public_dispatch +40 ❌ +0.14%
TokenBlacklist::update_roles +10 ❌ +0.13%
TokenBlacklist::constructor +10 ❌ +0.13%
Test::consume_message_from_arbitrary_sender_public +10 ❌ +0.13%
Test::consume_mint_to_public_message +10 ❌ +0.09%
TokenBridge::claim_public +10 ❌ +0.08%
Uniswap::swap_public +10 ❌ +0.06%
AvmTest::bulk_testing +10 ❌ +0.04%
Benchmarking::public_dispatch +1 ❌ +0.02%
CardGame::public_dispatch -16 ✅ -0.10%
Lending::_withdraw -12 ✅ -0.13%
Lending::_borrow -12 ✅ -0.13%
Token::_finalize_transfer_to_private_unsafe -12 ✅ -0.16%
CardGame::on_cards_claimed -12 ✅ -0.16%
Token::finalize_transfer_to_private -12 ✅ -0.16%
Token::_finalize_mint_to_private_unsafe -12 ✅ -0.17%
Token::finalize_mint_to_private -12 ✅ -0.17%
NFT::_finalize_transfer_to_private_unsafe -12 ✅ -0.18%
NFT::finalize_transfer_to_private -12 ✅ -0.19%
Lending::_repay -12 ✅ -0.19%
CardGame::on_card_played -12 ✅ -0.20%
Lending::update_accumulator -12 ✅ -0.21%
Lending::get_position -12 ✅ -0.23%
CardGame::on_game_joined -12 ✅ -0.24%
Benchmarking::increment_balance -12 ✅ -0.32%
Token::mint_to_public -12 ✅ -0.34%
NFT::mint -12 ✅ -0.36%
Parent::public_nested_static_call -12 ✅ -0.36%
TokenBridge::constructor -12 ✅ -0.36%
Claim::constructor -12 ✅ -0.37%
Lending::init -12 ✅ -0.37%
FPC::constructor -12 ✅ -0.38%
Lending::_deposit -12 ✅ -0.39%
CardGame::start_game -29 ✅ -0.41%
TokenBlacklist::_increase_public_balance -12 ✅ -0.42%
Token::_increase_public_balance -12 ✅ -0.42%
NFT::owner_of -12 ✅ -0.43%
Spam::public_spam -12 ✅ -0.43%
FeeJuice::_increase_public_balance -12 ✅ -0.46%
EasyPrivateVoting::add_to_tally_public -12 ✅ -0.47%
FeeJuice::check_balance -12 ✅ -0.49%
Auth::get_authorized_delay -12 ✅ -0.50%
AvmTest::add_storage_map -12 ✅ -0.52%
Lending::get_asset -12 ✅ -0.54%
NFT::set_minter -12 ✅ -0.54%
Token::set_minter -12 ✅ -0.54%
StatefulTest::increment_public_value -12 ✅ -0.56%
AuthRegistry::is_consumable -12 ✅ -0.56%
TokenBlacklist::balance_of_public -12 ✅ -0.56%
Token::balance_of_public -12 ✅ -0.56%
StatefulTest::increment_public_value_no_init_check -12 ✅ -0.57%
FeeJuice::balance_of_public -12 ✅ -0.58%
AuthRegistry::_set_authorized -12 ✅ -0.58%
Auth::get_authorized -12 ✅ -0.58%
NFT::is_minter -12 ✅ -0.59%
Token::is_minter -12 ✅ -0.59%
AuthRegistry::set_authorized -12 ✅ -0.59%
Benchmarking::broadcast -12 ✅ -0.60%
PriceFeed::get_price -12 ✅ -0.60%
AuthRegistry::is_reject_all -12 ✅ -0.61%
StatefulTest::get_public_value -12 ✅ -0.61%
AvmTest::set_storage_map -12 ✅ -0.61%
PriceFeed::set_price -12 ✅ -0.61%
Auth::get_scheduled_authorized -12 ✅ -0.61%
AvmTest::read_storage_map -12 ✅ -0.62%
NFT::_finish_transfer_to_public -12 ✅ -0.62%
AuthRegistry::set_reject_all -12 ✅ -0.65%
AvmTest::get_args_hash -12 ✅ -0.66%
AvmTest::poseidon2_hash -12 ✅ -0.69%
Token::public_dispatch -536 ✅ -1.57%
Token::complete_refund -208 ✅ -3.43%

Full diff report 👇
Program Bytecode size in bytes (+/-) %
FPC::public_dispatch 8,473 (+84) +1.00%
InclusionProofs::public_dispatch 4,232 (+36) +0.86%
StaticChild::public_dispatch 3,178 (+26) +0.82%
AuthWitTest::public_dispatch 1,984 (+13) +0.66%
AuthRegistry::public_dispatch 8,515 (+49) +0.58%
Crowdfunding::public_dispatch 6,277 (+36) +0.58%
StaticParent::public_dispatch 7,378 (+39) +0.53%
Router::public_dispatch 2,625 (+13) +0.50%
AppSubscription::public_dispatch 5,060 (+23) +0.46%
StatefulTest::public_dispatch 8,175 (+36) +0.44%
Test::public_dispatch 20,364 (+88) +0.43%
DocsExample::public_dispatch 6,092 (+26) +0.43%
Child::public_dispatch 6,141 (+26) +0.43%
AvmInitializerTest::constructor 2,567 (+10) +0.39%
InclusionProofs::constructor 2,643 (+10) +0.38%
EasyPrivateVoting::public_dispatch 6,135 (+23) +0.38%
Spam::public_dispatch 3,843 (+14) +0.37%
TokenBlacklist::get_roles 2,795 (+10) +0.36%
PriceFeed::public_dispatch 4,072 (+14) +0.34%
Claim::public_dispatch 4,305 (+14) +0.33%
Uniswap::constructor 3,078 (+10) +0.33%
Auth::constructor 3,119 (+10) +0.32%
AuthRegistry::consume 3,244 (+10) +0.31%
EasyPrivateVoting::constructor 3,245 (+10) +0.31%
AvmInitializerTest::public_dispatch 3,452 (+10) +0.29%
NFT::public_dispatch 26,461 (+75) +0.28%
Crowdfunding::init 3,557 (+10) +0.28%
AppSubscription::constructor 3,712 (+10) +0.27%
NFT::transfer_in_public 3,736 (+10) +0.27%
StatefulTest::public_constructor 3,882 (+10) +0.26%
Uniswap::public_dispatch 25,076 (+62) +0.25%
TokenBlacklist::public_dispatch 25,366 (+62) +0.25%
TokenBlacklist::mint_private 4,316 (+10) +0.23%
FeeJuice::public_dispatch 6,349 (+14) +0.22%
TokenBlacklist::mint_public 4,633 (+10) +0.22%
Token::burn_public 4,711 (+10) +0.21%
Auth::public_dispatch 10,908 (+23) +0.21%
NFT::constructor 4,809 (+10) +0.21%
Token::transfer_in_public 4,819 (+10) +0.21%
Token::constructor 5,165 (+10) +0.19%
AvmTest::public_dispatch 61,361 (+114) +0.19%
TokenBlacklist::burn_public 5,900 (+10) +0.17%
Auth::set_authorized_delay 5,968 (+10) +0.17%
Auth::set_authorized 6,054 (+10) +0.17%
Parent::public_dispatch 8,514 (+14) +0.16%
TokenBridge::public_dispatch 22,192 (+36) +0.16%
TokenBlacklist::transfer_public 6,333 (+10) +0.16%
TokenBlacklist::shield 6,438 (+10) +0.16%
Uniswap::_approve_bridge_and_exit_input_asset_to_L1 6,473 (+10) +0.15%
Lending::public_dispatch 28,533 (+40) +0.14%
TokenBlacklist::update_roles 7,699 (+10) +0.13%
TokenBlacklist::constructor 7,938 (+10) +0.13%
Test::consume_message_from_arbitrary_sender_public 7,977 (+10) +0.13%
Test::consume_mint_to_public_message 11,104 (+10) +0.09%
TokenBridge::claim_public 12,956 (+10) +0.08%
Uniswap::swap_public 15,723 (+10) +0.06%
AvmTest::bulk_testing 23,795 (+10) +0.04%
Benchmarking::public_dispatch 5,660 (+1) +0.02%
CardGame::public_dispatch 16,243 (-16) -0.10%
Lending::_withdraw 9,273 (-12) -0.13%
Lending::_borrow 9,009 (-12) -0.13%
Token::_finalize_transfer_to_private_unsafe 7,362 (-12) -0.16%
CardGame::on_cards_claimed 7,338 (-12) -0.16%
Token::finalize_transfer_to_private 7,315 (-12) -0.16%
Token::_finalize_mint_to_private_unsafe 7,152 (-12) -0.17%
Token::finalize_mint_to_private 7,105 (-12) -0.17%
NFT::_finalize_transfer_to_private_unsafe 6,482 (-12) -0.18%
NFT::finalize_transfer_to_private 6,435 (-12) -0.19%
Lending::_repay 6,179 (-12) -0.19%
CardGame::on_card_played 5,947 (-12) -0.20%
Lending::update_accumulator 5,764 (-12) -0.21%
Lending::get_position 5,238 (-12) -0.23%
CardGame::on_game_joined 5,046 (-12) -0.24%
Benchmarking::increment_balance 3,713 (-12) -0.32%
Token::mint_to_public 3,525 (-12) -0.34%
NFT::mint 3,364 (-12) -0.36%
Parent::public_nested_static_call 3,364 (-12) -0.36%
TokenBridge::constructor 3,350 (-12) -0.36%
Claim::constructor 3,269 (-12) -0.37%
Lending::init 3,192 (-12) -0.37%
FPC::constructor 3,152 (-12) -0.38%
Lending::_deposit 3,041 (-12) -0.39%
CardGame::start_game 6,965 (-29) -0.41%
TokenBlacklist::_increase_public_balance 2,855 (-12) -0.42%
Token::_increase_public_balance 2,855 (-12) -0.42%
NFT::owner_of 2,796 (-12) -0.43%
Spam::public_spam 2,796 (-12) -0.43%
FeeJuice::_increase_public_balance 2,586 (-12) -0.46%
EasyPrivateVoting::add_to_tally_public 2,547 (-12) -0.47%
FeeJuice::check_balance 2,441 (-12) -0.49%
Auth::get_authorized_delay 2,398 (-12) -0.50%
AvmTest::add_storage_map 2,316 (-12) -0.52%
Lending::get_asset 2,209 (-12) -0.54%
NFT::set_minter 2,205 (-12) -0.54%
Token::set_minter 2,200 (-12) -0.54%
StatefulTest::increment_public_value 2,147 (-12) -0.56%
AuthRegistry::is_consumable 2,137 (-12) -0.56%
TokenBlacklist::balance_of_public 2,122 (-12) -0.56%
Token::balance_of_public 2,122 (-12) -0.56%
StatefulTest::increment_public_value_no_init_check 2,098 (-12) -0.57%
FeeJuice::balance_of_public 2,068 (-12) -0.58%
AuthRegistry::_set_authorized 2,054 (-12) -0.58%
Auth::get_authorized 2,041 (-12) -0.58%
NFT::is_minter 2,024 (-12) -0.59%
Token::is_minter 2,024 (-12) -0.59%
AuthRegistry::set_authorized 2,007 (-12) -0.59%
Benchmarking::broadcast 1,994 (-12) -0.60%
PriceFeed::get_price 1,988 (-12) -0.60%
AuthRegistry::is_reject_all 1,970 (-12) -0.61%
StatefulTest::get_public_value 1,960 (-12) -0.61%
AvmTest::set_storage_map 1,956 (-12) -0.61%
PriceFeed::set_price 1,946 (-12) -0.61%
Auth::get_scheduled_authorized 1,941 (-12) -0.61%
AvmTest::read_storage_map 1,929 (-12) -0.62%
NFT::_finish_transfer_to_public 1,929 (-12) -0.62%
AuthRegistry::set_reject_all 1,845 (-12) -0.65%
AvmTest::get_args_hash 1,804 (-12) -0.66%
AvmTest::poseidon2_hash 1,734 (-12) -0.69%
Token::public_dispatch 33,653 (-536) -1.57%
Token::complete_refund 5,848 (-208) -3.43%

@TomAFrench TomAFrench merged commit 8f41bee into master Nov 14, 2024
65 checks passed
@TomAFrench TomAFrench deleted the tf/pull-out-references-changes branch November 14, 2024 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants