Skip to content

Commit

Permalink
fix: Revert generator changes that cause memory OOB access
Browse files Browse the repository at this point in the history
  • Loading branch information
phated committed Apr 10, 2023
1 parent 3534e2b commit 8766253
Showing 1 changed file with 3 additions and 7 deletions.
10 changes: 3 additions & 7 deletions cpp/src/barretenberg/crypto/generators/generator_data.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -6,18 +6,14 @@ namespace {

// The number of unique base points with default main index with precomputed ladders
#ifdef __wasm__
constexpr size_t num_default_generators = 64;
constexpr size_t num_generators_per_hash_index = 16;
constexpr size_t num_hash_indices = 32;
// TODO need to resolve memory out of bounds when these are too high
constexpr size_t num_default_generators = 32;
#else
constexpr size_t num_default_generators = 2048;
constexpr size_t num_hash_indices = 32;
constexpr size_t num_generators_per_hash_index = 128;
#endif

constexpr size_t hash_indices_generator_offset = 2048;

constexpr size_t num_hash_indices = 16;
constexpr size_t num_generators_per_hash_index = 8;
constexpr size_t num_indexed_generators = num_hash_indices * num_generators_per_hash_index;
constexpr size_t size_of_generator_data_array = hash_indices_generator_offset + num_indexed_generators;
constexpr size_t num_generator_types = 3;
Expand Down

0 comments on commit 8766253

Please sign in to comment.