adding issue number to some TODOs

AztecProtocol · Apr 10, 2023 · 8ff9592 · 8ff9592
1 parent dee0b08
commit 8ff9592
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 7 deletions.
diff --git a/cpp/src/barretenberg/honk/composer/composer_helper/ultra_honk_composer_helper.cpp b/cpp/src/barretenberg/honk/composer/composer_helper/ultra_honk_composer_helper.cpp
@@ -49,11 +49,11 @@ void UltraHonkComposerHelper<CircuitConstructor>::compute_witness(CircuitConstru
         circuit_constructor.w_4.emplace_back(circuit_constructor.zero_idx);
     }
 
-    // TODO(luke): within compute_witness_base, the 3rd argument is used in the calculation of the dyadic circuit size
-    // (subgroup_size). Here (and in other split composers) we're passing in NUM_RANDOMIZED_GATES, but elsewhere, e.g.
-    // directly above, we use NUM_RESERVED_GATES in a similar role. Therefore, these two constants must be equal for
-    // everything to be consistent. What we should do is compute the dyadic circuit size once and for all then pass that
-    // around rather than computing in multiple places.
+    // TODO(#340)(luke): within compute_witness_base, the 3rd argument is used in the calculation of the dyadic circuit
+    // size (subgroup_size). Here (and in other split composers) we're passing in NUM_RANDOMIZED_GATES, but elsewhere,
+    // e.g. directly above, we use NUM_RESERVED_GATES in a similar role. Therefore, these two constants must be equal
+    // for everything to be consistent. What we should do is compute the dyadic circuit size once and for all then pass
+    // that around rather than computing in multiple places.
     wire_polynomials = compute_witness_base(circuit_constructor, total_num_gates, NUM_RANDOMIZED_GATES);
 
     polynomial s_1(subgroup_size);

diff --git a/cpp/src/barretenberg/honk/composer/composer_helper/ultra_honk_composer_helper.hpp b/cpp/src/barretenberg/honk/composer/composer_helper/ultra_honk_composer_helper.hpp
@@ -17,8 +17,8 @@ namespace proof_system::honk {
 // Cody: What does this mean?
 template <typename CircuitConstructor> class UltraHonkComposerHelper {
   public:
-    // TODO(luke): In the split composers, NUM_RANDOMIZED_GATES has replaced NUM_RESERVED_GATES (in some places) to
-    // determine the next-power-of-2 circuit size. (There are some places in this composer that still use
+    // TODO(#340)(luke): In the split composers, NUM_RANDOMIZED_GATES has replaced NUM_RESERVED_GATES (in some places)
+    // to determine the next-power-of-2 circuit size. (There are some places in this composer that still use
     // NUM_RESERVED_GATES). Therefore for consistency within this composer itself, and consistency with the original
     // Ultra Composer, this value must match that of NUM_RESERVED_GATES. This issue needs to be reconciled
     // simultaneously here and in the other split composers.