Upload Grumpkin SRS and download it in bb/bb.js #813
Comments
saleel
added a commit
to AztecProtocol/aztec-packages
that referenced
this issue
Sep 24, 2024
**Problem**: G1 data of CRS **[is not used](https://github.com/AztecProtocol/aztec-packages/blob/master/noir/noir-repo/tooling/noir_js_backend_barretenberg/src/verifier.ts#L35-L39)** for proof verification in both `BarretenbergVerifier` and `UltraHonkVerifier`, yet the entire file is being download. **Cause**: `numPoints` is set to zero in the verifiers, but `NetCrs` is downloading the entire 6 GB G1 file during verification as `g1End` will be `-1` and range header will become `bytes=0--1`. **Fix**: This PR fixes the issue by returning empty Uint8Array if required points is zero. Note: The same fix is not made in `GrumpkinCrs` as there is no calls with 0 points currently (maybe something to do with [#813](AztecProtocol/barretenberg#813))
AztecBot
pushed a commit
that referenced
this issue
Sep 25, 2024
**Problem**: G1 data of CRS **[is not used](https://github.com/AztecProtocol/aztec-packages/blob/master/noir/noir-repo/tooling/noir_js_backend_barretenberg/src/verifier.ts#L35-L39)** for proof verification in both `BarretenbergVerifier` and `UltraHonkVerifier`, yet the entire file is being download. **Cause**: `numPoints` is set to zero in the verifiers, but `NetCrs` is downloading the entire 6 GB G1 file during verification as `g1End` will be `-1` and range header will become `bytes=0--1`. **Fix**: This PR fixes the issue by returning empty Uint8Array if required points is zero. Note: The same fix is not made in `GrumpkinCrs` as there is no calls with 0 points currently (maybe something to do with [#813](#813))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
We should then update bb and bb.js both to download this if not found.
The text was updated successfully, but these errors were encountered: