You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently calldata_read_counts must be manually updated simultaneously with each calldata lookup gate. This is error prone. The polynomial calldata_read_counts should be computed all at once either in finalize or in the composer. One way to do this: Iterate through all databus lookup gates (looking for q_busread == 1), extract the read_index (stored in w_r), call get_variable on that index, convert the resulting field element to a size_t or uint32_t, then increment calldata_read_counts at the resulting index.
The text was updated successfully, but these errors were encountered:
Add a `read_calldata` method to clarify and robustify the interface to
calldata. Update the expository DataBus test accordingly.
Closes#821 (I was
proposing something weird in that issue but all I really wanted was for
the updating of read counts to be automated. That's achieved through
simply placing it in read_calldata).
Currently
calldata_read_counts
must be manually updated simultaneously with each calldata lookup gate. This is error prone. The polynomialcalldata_read_counts
should be computed all at once either infinalize
or in the composer. One way to do this: Iterate through all databus lookup gates (looking forq_busread == 1
), extract the read_index (stored inw_r
), call get_variable on that index, convert the resulting field element to asize_t
oruint32_t
, then incrementcalldata_read_counts
at the resulting index.The text was updated successfully, but these errors were encountered: