Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Computation of power polynomial is O(d * 2^d) instead of O(2^d) #864

Open
lucasxia01 opened this issue Feb 21, 2024 · 0 comments
Open

Computation of power polynomial is O(d * 2^d) instead of O(2^d) #864

lucasxia01 opened this issue Feb 21, 2024 · 0 comments

Comments

@lucasxia01
Copy link
Contributor

lucasxia01 commented Feb 21, 2024

We compute the power polynomial with an outer loop that iterates over 2^d (d being the log size and also the number of betas), and use a O(d) inner loop that multiplies the appropriate betas together. We can optimize this to O(2^d) method that is also easily parallelizable by computing a binary tree.

Started in this commit.

lucasxia01 added a commit to AztecProtocol/aztec-packages that referenced this issue Feb 23, 2024
Adds the pow poly bench. This PR was supposed to also optimize the pow
poly computation, but I measured that it takes around 45ms of the whole
6-iter client IVC benchmark, so its not worth doing for now.

Links a couple of optimization issues to the codebase:
AztecProtocol/barretenberg#857 and
AztecProtocol/barretenberg#864.
AztecBot pushed a commit that referenced this issue Feb 24, 2024
Adds the pow poly bench. This PR was supposed to also optimize the pow
poly computation, but I measured that it takes around 45ms of the whole
6-iter client IVC benchmark, so its not worth doing for now.

Links a couple of optimization issues to the codebase:
#857 and
#864.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant