Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bb.js is standalone prover that handles noir constraint/witness output. #471

Merged
merged 33 commits into from
Jun 1, 2023

Commits on May 21, 2023

  1. Initial

    charlielye committed May 21, 2023
    Configuration menu
    Copy the full SHA
    0038bb6 View commit details
    Browse the repository at this point in the history
  2. Separate thread build dir.

    charlielye committed May 21, 2023
    Configuration menu
    Copy the full SHA
    284eac2 View commit details
    Browse the repository at this point in the history

Commits on May 22, 2023

  1. Configuration menu
    Copy the full SHA
    afef842 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    4c39ac6 View commit details
    Browse the repository at this point in the history

Commits on May 23, 2023

  1. Configuration menu
    Copy the full SHA
    e1318c1 View commit details
    Browse the repository at this point in the history
  2. progress.

    charlielye committed May 23, 2023
    Configuration menu
    Copy the full SHA
    efc3926 View commit details
    Browse the repository at this point in the history
  3. Sumcheck improvements (#455)

    * convert partially evaluated polynomials from vectors to Polynomials and rename
    
    * rename fold method to partially_evaluate
    
    * static constexpr barycentric arrays
    
    * change purported evaluations to claimed evaluations
    
    * specify relations in Flavor
    ledwards2225 authored May 23, 2023
    Configuration menu
    Copy the full SHA
    0e7d32f View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    0e0b04d View commit details
    Browse the repository at this point in the history
  5. Fixed.

    charlielye committed May 23, 2023
    Configuration menu
    Copy the full SHA
    b2635b6 View commit details
    Browse the repository at this point in the history

Commits on May 24, 2023

  1. Configuration menu
    Copy the full SHA
    2a7e1d0 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    6477f82 View commit details
    Browse the repository at this point in the history
  3. Clean

    charlielye committed May 24, 2023
    Configuration menu
    Copy the full SHA
    f108b22 View commit details
    Browse the repository at this point in the history
  4. tests pass

    charlielye committed May 24, 2023
    Configuration menu
    Copy the full SHA
    130c944 View commit details
    Browse the repository at this point in the history
  5. Commander

    charlielye committed May 24, 2023
    Configuration menu
    Copy the full SHA
    72e4c98 View commit details
    Browse the repository at this point in the history
  6. Fix.

    charlielye committed May 24, 2023
    Configuration menu
    Copy the full SHA
    b600d99 View commit details
    Browse the repository at this point in the history
  7. Fix

    charlielye committed May 24, 2023
    Configuration menu
    Copy the full SHA
    e51ab64 View commit details
    Browse the repository at this point in the history
  8. Fix serve.

    charlielye committed May 24, 2023
    Configuration menu
    Copy the full SHA
    14acc50 View commit details
    Browse the repository at this point in the history
  9. Fix

    charlielye committed May 24, 2023
    Configuration menu
    Copy the full SHA
    e660b55 View commit details
    Browse the repository at this point in the history
  10. More commands.

    charlielye committed May 24, 2023
    Configuration menu
    Copy the full SHA
    d3278fd View commit details
    Browse the repository at this point in the history

Commits on May 25, 2023

  1. Configuration menu
    Copy the full SHA
    ad28215 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    ada5d9d View commit details
    Browse the repository at this point in the history
  3. Fix.

    charlielye committed May 25, 2023
    Configuration menu
    Copy the full SHA
    f815187 View commit details
    Browse the repository at this point in the history
  4. write_vk

    charlielye committed May 25, 2023
    Configuration menu
    Copy the full SHA
    0fee875 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    fa7984a View commit details
    Browse the repository at this point in the history
  6. DSL: Add KeccakVar opcode (#476)

    * add initial KeccakVar code
    
    * add result field
    
    * add keccak_var_constraints to fields
    kevaundray authored May 25, 2023
    Configuration menu
    Copy the full SHA
    0834791 View commit details
    Browse the repository at this point in the history
  7. Multi-constraint Relations (#444)

    Allow for correct and efficient batching over identities in the Sumcheck relation
    ledwards2225 authored May 25, 2023
    Configuration menu
    Copy the full SHA
    4d851dd View commit details
    Browse the repository at this point in the history

Commits on May 26, 2023

  1. Configuration menu
    Copy the full SHA
    dff766b View commit details
    Browse the repository at this point in the history

Commits on May 27, 2023

  1. Configuration menu
    Copy the full SHA
    97a2fdf View commit details
    Browse the repository at this point in the history
  2. Clean

    charlielye committed May 27, 2023
    Configuration menu
    Copy the full SHA
    04b6024 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    cf4b674 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    7065b1f View commit details
    Browse the repository at this point in the history
  5. Exclude env from lib.

    charlielye committed May 27, 2023
    Configuration menu
    Copy the full SHA
    7cfc53a View commit details
    Browse the repository at this point in the history

Commits on Jun 1, 2023

  1. feat(dsl)!: DSL recursion changes w/ bb.js (#485)

    * Added recursion constraint into dsl + tests
    
    * fix dsl ecdsa constraint. Added ecdsa dsl tests
    
    * changed dsl recursion to pass proof/key as witnesses
    
    * recursive verification key no longer encapsulates a native key
    
    recursive verification key no longer encapsulates a reference string
    
    (neither were fundamentally needed!)
    
    * added serialization test for acir_proofs
    
    * Added serialization methods into dsl for recursive proof composition
    
    Added passing serialization tests
    
    Fixed format of RecursionConstraint to be compatible with existing ACIR formatting
    
    * added verificaiton key hash into RecursionConstraint
    
    Can be used by backend to force recursive verification key to be a specific value (it is represented via witnesses and therefore is not by-default constraint to represent a specific circuit)
    
    * fixed compiler errors in stdlib_recursion_tests
    
    * feat(dsl)!: Noir recursion updates (#379)
    
    * merge master in zw/noir-recursion
    
    * add dsl files to commit
    
    * namespace stuff and debugging
    
    * c bind functions
    
    * constraint test and comment removal
    
    * revert some changes to RecursionConstraint while debugging serialization issues
    
    * dispaly error when trying to use create_circuit_with_witness
    
    * is_recursive flag as part of new_proof and verify_proof, new RecursiveProver type in dsl, and serialization changes for recursion acir_proofs methods
    
    * remove debug output from TestSerializationWithRecursion
    
    * master merge conflicts
    
    * EnvReferenceString undefined reference to  error workaround
    
    * add missing recursion_constraint field from acir_format tests
    
    * add recursion_constraints field back in acir_proofs.test inner circuit
    
    * fix inner circuit in RecursionConstraint.TestRecursionConstraint
    
    * Empty-Commit
    
    * add verify_recursive_proof method for simulating recursive verification in the ACVM
    
    * add ecc module to env package to fix linking of ennv_load_prover_crs and env_load_verifier_crs
    
    * add back reference strinng to stdlib recursion key to pass sol verifier generation tests
    
    * remove prints from recursive verifier test
    
    * fix dirty free for when serializing vk to fields, was working on macbook so not caught earlier, but need more clarity on ubuntu
    
    * fix ecdsa tests after master merge
    
    * missing keccak constraints fields in acir format and proofs tests
    
    * one more missing keccak constraint
    
    * mismatched acir format structs for gcc build
    
    * missing block constraints in acir tests
    
    * feat(dsl)!: Arbitrary depth recursion (#433)
    
    * merge conflicts and small updates to get acir_proofs test passing with arbitrary depth cahnges
    
    * inline with mv/noir-recursion and working double recursion acir_proofs serialization test
    
    * cleanup and working towards supporting full nested proofs, still some bugs in acir_proofs test
    
    * full recursive composition test working in acir_proofs
    
    * use two public inptus for inner circuit
    
    * delete commented out unnecessary acir proofs method
    
    * made dummy transcript points unique to prevent point collisions
    
    * handle nested proofs when exporting dummy transcript, export recursive proof indices when init vkey, fix full recursive comp test in acir_proofs
    
    * update bindings on verify_recursive_proof to accept num public inputs
    
    * missing acir_format field in tests
    
    * missing one more correct acir_format struct in recursion constraint test
    
    * cleanup and additional comment for recursion_constraint
    
    * fix up comment in recursion_constraint
    
    * remove unnecesary comments when we were including proof outputs as public inputs in the recursion constraint
    
    ---------
    
    Co-authored-by: zac-williamson <blorktronics@gmail.com>
    
    * move export key into dsl package
    
    * chore: remove unused export key in recursion format from main proof system classes
    
    * pr review: moved from_witness comment and renamed from_field_pt_vector
    
    * moved export transcript in recursion format to DSL package
    
    * move order of acir functions
    
    * remove ecc bb_module declaration in env package
    
    * chore: remove usage of magic numbers when slicing g1::affine_element into barretenberg::fr
    
    * introduce NUM_AGGREGATION_ELEMENTS constant and use it through recursion constraint
    
    * nit ASSERT(result != -1) in get_public_input_index
    
    * remove unused found var
    
    * cast -1
    
    * fix up verify_recursive_proof and add a test for it
    
    * moved from tempalte for has_valid_witness_assignments to a flag
    
    * chore: add comments to AcirProofs.TestVerifyRecursiveProofPass
    
    * update prove and verify exports to handle is_recursive
    
    * remove install state
    
    * remove debug output and use total_circuit_size
    
    * remove verify_recursive_proof as we might not need it for simulation
    
    * switch how we do is_recursive
    
    * remove acir recursive simulation method
    
    * changed wasi stubs and removed cout from acir_init_proving_key
    
    * removed cout outs getting runtime error for func definition
    
    * working recursion format funcs, but strangely getting errors about trying to invert zero in the field for dummy transcript and key
    
    * most recent debug output, hitting bad alloc in compute_proving_key_base
    
    * delete old comment
    
    * bb.js cmd changes
    
    * Lint and default fixes.
    
    * cleanup info and debug comments
    
    * add comment to recursion serialization methods
    
    * match package.json on cl/acir_cbinds
    
    * don't remove EventEmitter from bb_wasm.ts
    
    * delete empty exports file
    
    * use process.exit
    
    * log
    
    * add comment for why CIRCUIT_SIZE is 2**18
    
    * mising keccak var constraints in new acir format tests
    
    * Cleanup some serialization.
    
    * Cleanup for publishing. README.
    
    ---------
    
    Co-authored-by: zac-williamson <blorktronics@gmail.com>
    Co-authored-by: Charlie Lye <karl.lye@gmail.com>
    3 people authored Jun 1, 2023
    Configuration menu
    Copy the full SHA
    3683800 View commit details
    Browse the repository at this point in the history