UltraHonk Benchmarks #477
Merged
UltraHonk Benchmarks #477
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ledwards2225
force-pushed
the
lde/benchmark_workflow
branch
5 times, most recently
from
dc8085e
to
5712466
Compare
ledwards2225
force-pushed
the
lde/benchmark_workflow
branch
from
f4935d8
to
2bf4cad
Compare
Closed
Closed
ledwards2225
force-pushed
the
lde/benchmark_workflow
branch
from
5140837
to
7307ff6
Compare
Rumata888
reviewed
Jun 1, 2023
| @@ -58,12 +61,15 @@ class UltraCircuitConstructor; | |||
|
|
|||
| #define EXTERN_STDLIB_ULTRA_TYPE(stdlib_type) \ | |||
| extern template class stdlib_type<proof_system::UltraCircuitConstructor>; \ | |||
| extern template class stdlib_type<plonk::UltraPlonkComposer>; | |||
| extern template class stdlib_type<plonk::UltraPlonkComposer>; \ | |||
| // extern template class stdlib_type<honk::UltraHonkComposer>; | |||
There was a problem hiding this comment.
Why is this commented out?
There was a problem hiding this comment.
whoops - thanks
Rumata888
reviewed
Jun 1, 2023
| { | ||
| auto num_gates = 1 << (size_t)state.range(0); |
There was a problem hiding this comment.
You can use range multiplier (https://github.com/google/benchmark/blob/main/docs/user_guide.md#custom-counters) as an alternative if you want the exponent to be the metric.
There was a problem hiding this comment.
Thanks, I feel like there's lots of fun capabilities here that I need to dig into. For now I'll leave it as is since I'm not even sure we care about the standard honk benchmarks much anymore
Rumata888
reviewed
Jun 1, 2023
| // Number of times to perform operation of interest in the benchmark circuits, e.g. # of hashes to perform | ||
| constexpr size_t MIN_NUM_ITERATIONS = 10; | ||
| constexpr size_t MAX_NUM_ITERATIONS = 10; | ||
| // Numeber of times to repeat each benchmark |
ledwards2225
force-pushed
the
lde/benchmark_workflow
branch
from
378fe74
to
e92b89e
Compare
ludamad
pushed a commit
to AztecProtocol/aztec-packages
that referenced
this pull request
Jul 22, 2023
* basic benchmarks for ultra honk * remove github action workflow altogether for now * update compare script
ludamad
pushed a commit
to AztecProtocol/aztec-packages
that referenced
this pull request
Jul 24, 2023
* basic benchmarks for ultra honk * remove github action workflow altogether for now * update compare script
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
First component of #480: Introduces a suite of UltraHonk benchmarks for proof construction for four different circuits, each of which contains a specified number (currently 10) of one of the following individual operations:
Additional required changes in this PR include instantiation of stdlib types with UltraHonkComposer and introduction of several required methods in the UltraHonkComposer (all of which are pass-throughs to existing methods in the UltraCircuitConstructor).
Checklist:
/markdown/specshave been updated.@briefdescribing the intended functionality.