-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(api): external cpp header for circuits #489
Conversation
…t break when aztec PR is merged to master
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As noted, I never intended
#include "serialize/cbind.hpp"
#include "serialize/msgpack.hpp"
#include "serialize/test_helper.hpp"
To be exposed to header files. It may slow down compilation (although only really if we have a lot of .cpp files). Otherwise LGTM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this. This is crucial as a first step, and in that sense it looks right to me. That said, this API is really large and hence we can expect regular breaking changes until we can pare it down as discussed earlier today.
…rg#489) * missing header includes * comments in api header with issues/todos
…rg#489) * missing header includes * comments in api header with issues/todos
Description
After this PR is merged followed by its blocked aztec PR,
.aztec-packages-commit
can be set to master or latest aztec master commit.Checklist:
/markdown/specs
have been updated.@brief
describing the intended functionality.