Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: cleanup of include statements #527

Merged
merged 3 commits into from
Jun 16, 2023
Merged

fix: cleanup of include statements #527

merged 3 commits into from
Jun 16, 2023

Conversation

codygunton
Copy link
Collaborator

@codygunton codygunton commented Jun 13, 2023 •
edited by maramihali
Loading

Cleanup include statments

Ensure that composers_fwd.hpp and composers.hpp used for forward declaration in stdlib are not used anywhere else. Further cleanup so honk doesn't depend on plonk anymore

Checklist:

  • I have reviewed my diff in github, line by line.
  • Every change is related to the PR description.
  • I have linked this pull request to the issue(s) that it resolves.
  • There are no unexpected formatting changes, superfluous debug logs, or commented-out code.
  • There are no circuit changes, OR specifications in /markdown/specs have been updated.
  • There are no circuit changes, OR a cryptographer has been assigned for review.
  • I've updated any terraform that needs updating (e.g. environment variables) for deployment.
  • The branch has been rebased against the head of its merge target.
  • I'm happy for the PR to be merged at the reviewer's next convenience.
  • New functions, classes, etc. have been documented according to the doxygen comment format. Classes and structs must have @brief describing the intended functionality.
  • If existing code has been modified, such documentation has been added or updated.

@codygunton codygunton changed the title Include cleanup fix: Include cleanup Jun 13, 2023
@kevaundray kevaundray changed the title fix: Include cleanup fix: cleanup of include statements Jun 13, 2023
@maramihali maramihali force-pushed the cg/plonk-dep-cleanup branch 2 times, most recently from 9691ba8 to e7829fa Compare June 15, 2023 09:23
@maramihali maramihali marked this pull request as ready for review June 15, 2023 09:27
codygunton
codygunton commented Jun 16, 2023
View reviewed changes
Copy link
Collaborator Author

@codygunton codygunton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Since I started this PR I can't approve it, so could you approve and merge after rebasing?

@maramihali maramihali self-requested a review June 16, 2023 14:48
@maramihali maramihali merged commit b288c24 into master Jun 16, 2023
@maramihali maramihali deleted the cg/plonk-dep-cleanup branch June 16, 2023 15:00
@github-actions github-actions bot mentioned this pull request Jun 16, 2023
Merged
@github-actions github-actions bot mentioned this pull request Jul 11, 2023
Merged
ludamad pushed a commit to AztecProtocol/aztec-packages that referenced this pull request Jul 22, 2023
@codygunton
fix: cleanup of include statements and dependencies (AztecProtocol/ba…
873d77f 
…rretenberg#527)

Ensure honk does not depend on plonk anymore. Remove use of the stdlib composer headers used for forward declaration outside stdlib.
Co-authored-by: maramihali <mara@aztecprotocol.com>, codygunton <cody@aztecprotocol.com>
ludamad pushed a commit to AztecProtocol/aztec-packages that referenced this pull request Jul 24, 2023
@codygunton
fix: cleanup of include statements and dependencies (AztecProtocol/ba…
0c7b5e2 
…rretenberg#527)

Ensure honk does not depend on plonk anymore. Remove use of the stdlib composer headers used for forward declaration outside stdlib.
Co-authored-by: maramihali <mara@aztecprotocol.com>, codygunton <cody@aztecprotocol.com>
This was referenced Jul 25, 2023
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maramihali maramihali maramihali approved these changes

Assignees

@maramihali maramihali

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@codygunton @maramihali