feat: Support public inputs in Ultra Honk #581

ledwards2225 · 2023-07-05T16:04:17Z

Description

The primary goal of this PR is to support public inputs in Ultra Honk. This was previously not supported because adding a non-zero public input to an UH circuit would result in wires with a non-zero first entry, making them not shiftable. The solution is to add a "zero row" at the start of the execution trace for all UH circuits. The ordering of the execution trace is thus: zero row, public inputs, conventional gates.

A portion of the work in this PR is simply cleanup that was necessary to limit the number of places in the code where we need to specify the "zero row offset". For example, this offset has to be taken into account in the computation of the dyadic circuit size, which was previously computed independently in 3 separate locations within the Honk composers.

Note about implementation: In general there are many "zero rows" in every circuit, i.e. the padding between the "filled" rows of the execution trace and the dyadic (power of 2) circuit size. For this reason, 0 is added as a variable in the circuit builders by default. To add a zero row at the start of the execution trace, I simply add the first index of each wire to the copy cycle associated with the variable 0. Whether or not this zero row is utilized is specified in the Flavor, since, for example, it is not needed for plonk variants or even Standard Honk.

Checklist:

ledwards2225 · 2023-07-17T15:22:01Z

cpp/src/barretenberg/honk/transcript/transcript.test.cpp

@@ -87,7 +89,7 @@ template <typename Flavor> class TranscriptTests : public testing::Test {
        round++;
        // TODO(Mara): Make testing more flavor agnostic so we can test this with all flavors
        if constexpr (IsGrumpkinFlavor<Flavor>) {
-            manifest_expected.add_entry(round, "IPA:poly_degree", circuit_size);
+            manifest_expected.add_entry(round, "IPA:poly_degree", size_uint64);


This was a bug in the test that was revealed by the work in this PR but is otherwise unrelated.

ledwards2225 · 2023-07-17T15:23:13Z

cpp/src/barretenberg/plonk/composer/composer_lib.hpp

@@ -9,6 +9,57 @@ struct SelectorProperties {
    bool requires_lagrange_base_polynomial = false;
 };

+/**


These two functions were formerly in the shared composer lib but they are used only for plonk so they've been moved to the plonk specific composer lib

ledwards2225 · 2023-07-17T15:26:21Z

cpp/src/barretenberg/proof_system/composer/composer_helper_lib.hpp

@@ -1,179 +0,0 @@
-#pragma once


This file was an exact copy of composer_lib and was not used at all so I've deleted it entirely.

ledwards2225 · 2023-07-17T17:19:01Z

cpp/src/barretenberg/honk/composer/ultra_composer.cpp

@@ -251,33 +249,6 @@ std::shared_ptr<typename Flavor::ProvingKey> UltraComposer_<Flavor>::compute_pro

    // Polynomial memory is zeroed out when constructed with size hint, so we don't have to initialize trailing space

-    // // In the case of using UltraPlonkComposer for a circuit which does _not_ make use of any lookup tables, all


This is the Plonk strategy for ensuring non-zero polys. We wont ever use this for Honk.

ledwards2225 · 2023-07-17T17:19:43Z

cpp/src/barretenberg/honk/composer/ultra_composer.cpp


    construct_selector_polynomials<Flavor>(circuit_constructor, proving_key.get());

-    // TODO(#217)(luke): Naively enforcing non-zero selectors for Honk will result in some relations not being


This is the Plonk strategy for ensuring non-zero polys. We wont ever use this for Honk.

Rumata888 · 2023-07-18T18:15:24Z

cpp/src/barretenberg/honk/composer/ultra_composer.hpp

@@ -36,6 +38,11 @@ template <UltraFlavor Flavor> class UltraComposer_ {
    std::vector<uint32_t> recursive_proof_public_input_indices;
    bool contains_recursive_proof = false;
    bool computed_witness = false;
+    size_t total_num_gates = 0; // num_gates + num_pub_inputs + tables + zero_row_offset (used to compute dyadic size)
+    size_t dyadic_circuit_size = 0; // final dyadic circuit size


I'd recommend adding (next power of two) in the comments. As a variable name dyadic is ok, but for me it wasn't clear from the start if this is supposed to be the logarithm or the power of 2

good call - done

Rumata888 · 2023-07-18T18:22:49Z

cpp/src/barretenberg/honk/flavor/standard.hpp

@@ -66,6 +66,9 @@ class Standard {
    using RelationUnivariates = decltype(create_relation_univariates_container<FF, Relations>());
    using RelationValues = decltype(create_relation_values_container<FF, Relations>());

+    // Whether or not the first row of the execution trace is reserved for 0s to enable shifts
+    static constexpr bool has_zero_row = false;


Don't we need it for all honk flavors?

Rumata888 · 2023-07-18T18:23:11Z

cpp/src/barretenberg/honk/flavor/standard_grumpkin.hpp

-    // define utilities to extend univarates from RELATION_LENGTH to MAX_RELATION_LENGTH for each Relation
-    // using BarycentricUtils = decltype(create_barycentric_utils<FF, Relations, MAX_RELATION_LENGTH>());
+    // Whether or not the first row of the execution trace is reserved for 0s to enable shifts
+    static constexpr bool has_zero_row = false;


Don't we need it for all honk flavors?

No need for the zero row for Standard flavors since in this case the only shifted poly is z_perm which is constructed explicitly with a constant coeff equal to 0. The problem arises for UltraHonk since we need to shift the wire polys themselves

…#581)

ledwards2225 changed the title ~~Cleaning up circuit size params in honk composers~~ chore: Cleaning up circuit size params in honk composers Jul 5, 2023

codygunton assigned ledwards2225 Jul 5, 2023

ledwards2225 force-pushed the lde/composer_cleanup branch from 808a4ce to fb6d7f8 Compare July 6, 2023 10:29

kevaundray changed the title ~~chore: Cleaning up circuit size params in honk composers~~ chore Cleaning up circuit size params in honk composers Jul 7, 2023

kevaundray changed the title ~~chore Cleaning up circuit size params in honk composers~~ chore: Cleaning up circuit size params in honk composers Jul 7, 2023

kevaundray changed the title ~~chore: Cleaning up circuit size params in honk composers~~ chore: Cleaning up circuit size parameters in honk composers Jul 10, 2023

ledwards2225 force-pushed the lde/composer_cleanup branch from 34cbf10 to b5b6dba Compare July 16, 2023 21:23

ledwards2225 changed the title ~~chore: Cleaning up circuit size parameters in honk composers~~ chore: Support public inputs in Ultra Honk Jul 17, 2023

ledwards2225 commented Jul 17, 2023

View reviewed changes

ledwards2225 changed the title ~~chore: Support public inputs in Ultra Honk~~ feat: Support public inputs in Ultra Honk Jul 17, 2023

ledwards2225 marked this pull request as ready for review July 17, 2023 16:25

ledwards2225 force-pushed the lde/composer_cleanup branch from 85b2328 to cc22a28 Compare July 17, 2023 16:58

ledwards2225 commented Jul 17, 2023

View reviewed changes

ledwards2225 linked an issue Jul 17, 2023 that may be closed by this pull request

Allow UltraHonk to handle public inputs #579

Closed

ledwards2225 requested a review from Rumata888 July 17, 2023 18:34

ledwards2225 added 12 commits July 18, 2023 18:15

Cleaning up circuit size params in honk composers

37a625e

move init pkey fctn from shared to plonk specific

39acaf0

clean up witness base

77ab404

move size param setting outside pkey

a286c85

move enforce zero to plonk

0ed5ebb

add pub input 0 by default

841a7b5

set circuit size params within a function

de27e4d

WiP failing with offset greater than 0

fc062a3

everything working with offset 1

abcb185

move zero row spec to flavor

60fc7f4

template by flav to acces zero row bool

6d59260

comments and renaming

71901ac

ledwards2225 force-pushed the lde/composer_cleanup branch from cc22a28 to 71901ac Compare July 18, 2023 18:15

Rumata888 approved these changes Jul 18, 2023

View reviewed changes

power of 2 clarification

4a1f18a

ledwards2225 merged commit 9cd0a06 into master Jul 18, 2023

ledwards2225 deleted the lde/composer_cleanup branch July 18, 2023 20:18

github-actions bot mentioned this pull request Jul 18, 2023

chore(barretenberg): Release 0.3.4 #618

Merged

ludamad pushed a commit to AztecProtocol/aztec-packages that referenced this pull request Jul 22, 2023

feat: Support public inputs in Ultra Honk (AztecProtocol/barretenberg…

edc0f3f

…#581)

ludamad pushed a commit to AztecProtocol/aztec-packages that referenced this pull request Jul 24, 2023

feat: Support public inputs in Ultra Honk (AztecProtocol/barretenberg…

a8aee43

…#581)

This was referenced Jul 25, 2023

chore(aztec-sandbox): Release 0.2.0-alpha27 AztecProtocol/aztec-packages#1180

Closed

chore(aztec-sandbox): Release 0.2.0 AztecProtocol/aztec-packages#1181

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: Support public inputs in Ultra Honk #581

feat: Support public inputs in Ultra Honk #581

ledwards2225 commented Jul 5, 2023 •

edited

Loading

ledwards2225 Jul 17, 2023

ledwards2225 Jul 17, 2023

ledwards2225 Jul 17, 2023

ledwards2225 Jul 17, 2023

ledwards2225 Jul 17, 2023

Rumata888 Jul 18, 2023

ledwards2225 Jul 18, 2023

Rumata888 Jul 18, 2023

Rumata888 Jul 18, 2023

ledwards2225 Jul 18, 2023

		@@ -251,33 +249,6 @@ std::shared_ptr<typename Flavor::ProvingKey> UltraComposer_<Flavor>::compute_pro

		// Polynomial memory is zeroed out when constructed with size hint, so we don't have to initialize trailing space

		// // In the case of using UltraPlonkComposer for a circuit which does _not_ make use of any lookup tables, all


		construct_selector_polynomials<Flavor>(circuit_constructor, proving_key.get());

		// TODO(#217)(luke): Naively enforcing non-zero selectors for Honk will result in some relations not being

feat: Support public inputs in Ultra Honk #581

feat: Support public inputs in Ultra Honk #581

Conversation

ledwards2225 commented Jul 5, 2023 • edited Loading

Description

Checklist:

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ledwards2225 commented Jul 5, 2023 •

edited

Loading