Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(dsl): Add ECDSA secp256r1 verification #582

Merged
merged 10 commits into from
Jul 10, 2023
Merged

feat(dsl): Add ECDSA secp256r1 verification #582

merged 10 commits into from
Jul 10, 2023

Conversation

Maddiaa0
Copy link
Member

@Maddiaa0 Maddiaa0 commented Jul 5, 2023 •
edited
Loading

Description

Work done during the hackathon to get secp256r1 working in noir.

Checklist:

  • I have reviewed my diff in github, line by line.
  • Every change is related to the PR description.
  • The branch has been merged with/rebased against the head of its merge target.
  • There are no unexpected formatting changes, superfluous debug logs, or commented-out code.
  • There are no circuit changes, OR a cryptographer has been assigned for review.
  • New functions, classes, etc. have been documented according to the doxygen comment format. Classes and structs must have @brief describing the intended functionality.
  • If existing code has been modified, such documentation has been added or updated.
  • No superfluous include directives have been added.
  • I have linked to any issue(s) it resolves.
  • I'm happy for the PR to be merged at the reviewer's next convenience.

@Maddiaa0 Maddiaa0 requested a review from kevaundray July 5, 2023 16:05
@Maddiaa0 Maddiaa0 marked this pull request as ready for review July 7, 2023 17:37
@kevaundray kevaundray changed the title feat(dsl): secp256r1 against master feat(dsl): Add ECDSA secp256r1 verification Jul 8, 2023
kevaundray
kevaundray reviewed Jul 8, 2023
View reviewed changes
Copy link
Contributor

@kevaundray kevaundray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall, left some comments re this passing for k1 and not r1.

Once the open comments have been resolved, this is good to merge

@kevaundray kevaundray mentioned this pull request Jul 8, 2023
Open
@kevaundray kevaundray merged commit adc4c7b into master Jul 10, 2023
@kevaundray kevaundray deleted the md/hacka-masterr branch July 10, 2023 08:37
This was referenced Jul 8, 2023
Merged
Merged
ludamad pushed a commit to AztecProtocol/aztec-packages that referenced this pull request Jul 22, 2023
@Maddiaa0
feat(dsl): Add ECDSA secp256r1 verification (AztecProtocol/barretenbe…
6e27899 
…rg#582)
ludamad pushed a commit to AztecProtocol/aztec-packages that referenced this pull request Jul 24, 2023
@Maddiaa0
feat(dsl): Add ECDSA secp256r1 verification (AztecProtocol/barretenbe…
c3560dd 
…rg#582)
This was referenced Jul 25, 2023
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevaundray kevaundray kevaundray left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Maddiaa0 @kevaundray