Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add get_sibling_path method in MerkleTree #584

Merged
merged 8 commits into from
Jul 11, 2023
Merged

feat: Add get_sibling_path method in MerkleTree #584

merged 8 commits into from
Jul 11, 2023

Conversation

benesjan
Copy link
Contributor

@benesjan benesjan commented Jul 6, 2023

Description

Implementation of get_sibling_path method in MerkleTree.

Checklist:

  • I have reviewed my diff in github, line by line.
  • Every change is related to the PR description.
  • The branch has been merged with/rebased against the head of its merge target.
  • There are no unexpected formatting changes, superfluous debug logs, or commented-out code.
  • There are no circuit changes, OR a cryptographer has been assigned for review.
  • New functions, classes, etc. have been documented according to the doxygen comment format. Classes and structs must have @brief describing the intended functionality.
  • If existing code has been modified, such documentation has been added or updated.
  • No superfluous include directives have been added.
  • I have linked to any issue(s) it resolves.
  • I'm happy for the PR to be merged at the reviewer's next convenience.

@benesjan benesjan marked this pull request as draft July 6, 2023 13:39
@benesjan benesjan changed the title get_sibling_path method in MerkleTree feat: get_sibling_path method in MerkleTree Jul 6, 2023
@benesjan benesjan marked this pull request as ready for review July 6, 2023 15:04
@benesjan benesjan requested a review from suyash67 July 6, 2023 15:04
@kevaundray kevaundray changed the title feat: get_sibling_path method in MerkleTree feat: Add get_sibling_path method in MerkleTree Jul 7, 2023
@benesjan benesjan mentioned this pull request Jul 10, 2023
Closed
10 tasks
@benesjan benesjan force-pushed the janb/get_sibling_path_in_merkle_tree branch from 6eb3a0c to b80820e Compare July 11, 2023 13:02
@benesjan benesjan merged commit b3db9f8 into master Jul 11, 2023
@benesjan benesjan deleted the janb/get_sibling_path_in_merkle_tree branch July 11, 2023 13:37
This was referenced Jul 11, 2023
Merged
Merged
ludamad pushed a commit to AztecProtocol/aztec-packages that referenced this pull request Jul 22, 2023
@benesjan
feat: Add get_sibling_path method in MerkleTree (AztecProtocol/barr…
6b8289a 
…etenberg#584)
ludamad pushed a commit to AztecProtocol/aztec-packages that referenced this pull request Jul 24, 2023
@benesjan
feat: Add get_sibling_path method in MerkleTree (AztecProtocol/barr…
f4321b3 
…etenberg#584)
This was referenced Jul 25, 2023
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@suyash67 suyash67 suyash67 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@benesjan @suyash67