Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: bb and bb.js directly parse nargo bincode format. #610

Merged
merged 8 commits into from
Jul 17, 2023
Merged

feat: bb and bb.js directly parse nargo bincode format. #610

merged 8 commits into from
Jul 17, 2023

Conversation

charlielye
Copy link
Contributor

Description

As title.

Checklist:

  • I have reviewed my diff in github, line by line.
  • Every change is related to the PR description.
  • The branch has been merged with/rebased against the head of its merge target.
  • There are no unexpected formatting changes, superfluous debug logs, or commented-out code.
  • There are no circuit changes, OR a cryptographer has been assigned for review.
  • New functions, classes, etc. have been documented according to the doxygen comment format. Classes and structs must have @brief describing the intended functionality.
  • If existing code has been modified, such documentation has been added or updated.
  • No superfluous include directives have been added.
  • I have linked to any issue(s) it resolves.
  • I'm happy for the PR to be merged at the reviewer's next convenience.

ludamad
ludamad reviewed Jul 15, 2023
View reviewed changes
cpp/src/barretenberg/dsl/acir_format/acir_to_constraint_buf.hpp
{
std::visit(
[&](auto&& arg) {
using T = std::decay_t<decltype(arg)>;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thoughts on this instead being an overloaded function call? Feels a bit clever :)

@charlielye charlielye merged commit d25e37a into master Jul 17, 2023
@charlielye charlielye deleted the cl/bb_parses_bincode branch July 17, 2023 16:57
@github-actions github-actions bot mentioned this pull request Jul 17, 2023
Merged
@Savio-Sou Savio-Sou mentioned this pull request Jul 19, 2023
Closed
ludamad pushed a commit to AztecProtocol/aztec-packages that referenced this pull request Jul 22, 2023
@charlielye
feat: bb and bb.js directly parse nargo bincode format. (AztecProtoco…
7d3be03 
…l/barretenberg#610)
ludamad pushed a commit to AztecProtocol/aztec-packages that referenced this pull request Jul 24, 2023
@charlielye
feat: bb and bb.js directly parse nargo bincode format. (AztecProtoco…
e96c90f 
…l/barretenberg#610)
This was referenced Jul 25, 2023
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ludamad ludamad ludamad left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@charlielye @ludamad