Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update references to Notes to use nullifier keys #279

Closed
3 tasks
critesjosh opened this issue May 15, 2024 · 1 comment · Fixed by AztecProtocol/aztec-packages#6538
Closed
3 tasks

Update references to Notes to use nullifier keys #279

critesjosh opened this issue May 15, 2024 · 1 comment · Fixed by AztecProtocol/aztec-packages#6538
Assignees
@catmcgee
Labels
Aztec Docs

Comments

@critesjosh
Copy link
Collaborator

critesjosh commented May 15, 2024 •
edited
Loading

Do to keys and key rotation being updated, Notes now use the nullifier_key instead of an address to indicate ownership of a note.

Things to update:

  • any Note references
  • adding the pattern to common_patterns.md -- devs need to remember that these keys can be rotated!
  • include an explanation / example code for how to handle key rotation

slack reference: https://aztecprotocol.slack.com/archives/C049J23DN64/p1715261619302879
@critesjosh critesjosh mentioned this issue May 15, 2024
Open
@jzaki jzaki self-assigned this May 16, 2024
@jzaki
Copy link
Contributor

jzaki commented May 16, 2024 •
edited
Loading

Related AztecProtocol/aztec-packages#6387
"Update references due to Notes to using nullifier keys"

@jzaki jzaki assigned catmcgee and unassigned jzaki May 17, 2024
@catmcgee catmcgee mentioned this issue May 20, 2024
Merged
catmcgee added a commit to AztecProtocol/aztec-packages that referenced this issue May 20, 2024
@catmcgee
feat(docs): Key rotation / owner -> nullifier key docs (#6538)
2453ba8 
Closes AztecProtocol/dev-rel#279
sklppy88 pushed a commit to AztecProtocol/aztec-packages that referenced this issue May 21, 2024
@catmcgee @sklppy88
feat(docs): Key rotation / owner -> nullifier key docs (#6538)
3fc397f 
Closes AztecProtocol/dev-rel#279
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@catmcgee catmcgee

Labels
Aztec Docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(docs): Key rotation / owner -> nullifier key docs AztecProtocol/aztec-packages
3 participants
@jzaki @critesjosh @catmcgee