Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docs]: Update custom note docs #385

Closed
Tracked by #220
critesjosh opened this issue Sep 4, 2024 · 1 comment · Fixed by AztecProtocol/aztec-packages#8518
Closed
Tracked by #220

[docs]: Update custom note docs #385

critesjosh opened this issue Sep 4, 2024 · 1 comment · Fixed by AztecProtocol/aztec-packages#8518
Assignees
@catmcgee
Labels
Aztec Docs

Comments

@critesjosh
Copy link
Collaborator

critesjosh commented Sep 4, 2024 •
edited
Loading

feedback from a community member. These are some questions they had that they could not find answers to.

explain what does #[aztec(note)] do. Explain each field. Why do we need randomness, why do we need npk_m_hash, what does serialize_content, explain context.request_nsk_app, explain get_nsk_app(self.npk_m_hash). What if there is no npk_m_hash(in case of a multisig, i believe)? Why is trait Eq is implemented manually instead of #[derive(Eq)]?
@catmcgee catmcgee mentioned this issue Sep 12, 2024
Merged
@catmcgee
Copy link
Collaborator

small changes for now but this + general notes docs will be fixed in this issue #346

@catmcgee catmcgee mentioned this issue Sep 9, 2024
Open
catmcgee added a commit to AztecProtocol/aztec-packages that referenced this issue Sep 18, 2024
@catmcgee @critesjosh
feat(docs): some small custom note stuff (#8518)
a098d41 
closes AztecProtocol/dev-rel#385

---------

Co-authored-by: josh crites <critesjosh@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@catmcgee catmcgee

Labels
Aztec Docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(docs): some small custom note stuff AztecProtocol/aztec-packages
2 participants
@critesjosh @catmcgee