feat: add otel spec #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
just-mitch
reviewed
Jun 13, 2024
| - we will use base units for values (e.g. `bytes` over `kilobytes` and `seconds` over `milliseconds`) | ||
| - we will _not_ include the unit in the name (there's a separate attribute for that, see code examples) | ||
|
|
||
| TBD `meter` naming conventions (ie. `metrics.getMeter('RealPublicKernelCircuitSimulator')`) |
There was a problem hiding this comment.
Class name seems reasonable to me!
just-mitch
reviewed
Jun 13, 2024
| public async publicKernelCircuitSetup(input: PublicKernelCircuitPrivateInputs): Promise<PublicKernelCircuitPublicInputs> { | ||
| // ... | ||
|
|
||
| this.circuitSimulationMetric.record(duration / 1000, { |
There was a problem hiding this comment.
Sorry, forgot to get back to you on this. The latest recommendation is to use seconds over milliseconds for duration metrics. I've updated the proving code to return a durationMs field instead of the unitless duration we had before.
just-mitch
approved these changes
Jun 13, 2024
PhilWindle
reviewed
Jun 14, 2024
| - [ ] AVM | ||
| - [x] Sequencer | ||
| - [ ] Fees | ||
| - [ ] P2P Network |
There was a problem hiding this comment.
Can we plug the metrics into the P2P module? Would be great if we can.
There was a problem hiding this comment.
I'll look into getting some stats out of it
PhilWindle
approved these changes
Jun 14, 2024
alexghr
force-pushed
the
alexg/feat/metrics
branch
from
82a22cf
to
a7a4245
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.