feat: makes the code output more granular, rather than creating one monolithic relation #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbanks12
pushed a commit
to AztecProtocol/aztec-packages
that referenced
this pull request
Nov 30, 2023
AztecProtocol/powdr#22 depends on the above. - We now have multiple different pil files to represent different submachines in our main vm circuit - This pr updates the codegen to match this, now powdr will create a different relations file for each, this allows us to perform witness generation for the submachines in isolation if we want to, and means that only the machines that were edited will be in the resulting diff in future prs --------- Co-authored-by: jeanmon <jean@aztecprotocol.com> Co-authored-by: Tom French <15848336+TomAFrench@users.noreply.github.com> Co-authored-by: Cat McGee <helloworld@mcgee.cat> Co-authored-by: josh crites <critesjosh@gmail.com> Co-authored-by: Alex Gherghisan <alexghr@users.noreply.github.com> Co-authored-by: Zachary James Williamson <blorktronics@gmail.com> Co-authored-by: lucasxia01 <lucasxia01@gmail.com> Co-authored-by: PhilWindle <60546371+PhilWindle@users.noreply.github.com>
AztecBot
pushed a commit
to AztecProtocol/barretenberg
that referenced
this pull request
Dec 2, 2023
AztecProtocol/powdr#22 depends on the above. - We now have multiple different pil files to represent different submachines in our main vm circuit - This pr updates the codegen to match this, now powdr will create a different relations file for each, this allows us to perform witness generation for the submachines in isolation if we want to, and means that only the machines that were edited will be in the resulting diff in future prs --------- Co-authored-by: jeanmon <jean@aztecprotocol.com> Co-authored-by: Tom French <15848336+TomAFrench@users.noreply.github.com> Co-authored-by: Cat McGee <helloworld@mcgee.cat> Co-authored-by: josh crites <critesjosh@gmail.com> Co-authored-by: Alex Gherghisan <alexghr@users.noreply.github.com> Co-authored-by: Zachary James Williamson <blorktronics@gmail.com> Co-authored-by: lucasxia01 <lucasxia01@gmail.com> Co-authored-by: PhilWindle <60546371+PhilWindle@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.