Fail silently if call to /api/app/updatedeploystatus fails (#146)

Azure-App-Service · Oct 29, 2020 · 47fcdd7 · 47fcdd7
1 parent 5f90c30
commit 47fcdd7
Showing 1 changed file with 4 additions and 4 deletions.
diff --git a/Kudu.Core/Helpers/PostDeploymentHelper.cs b/Kudu.Core/Helpers/PostDeploymentHelper.cs
@@ -642,11 +642,11 @@ public static async Task PostAsync(string path, string requestId, string content
             }
             catch (HttpRequestException ex)
             {
-                if (path.Equals(Constants.UpdateDeployStatusPath, StringComparison.OrdinalIgnoreCase) && statusCode == HttpStatusCode.NotFound)
+                if (path.Equals(Constants.UpdateDeployStatusPath, StringComparison.OrdinalIgnoreCase))
                 {
-                    // Fail silently if 404 is encountered.
-                    // This will only happen transiently during a platform upgrade if new bits aren't on the FrontEnd yet.
-                    Trace(TraceEventType.Warning, $"Call to {path} ended in 404. {ex}");
+                    // Fail silently if call to update dpeloyment status fails.
+                    // This makes sure we do not fail the build if this call fails
+                    Trace(TraceEventType.Warning, $"Call to {path} ended in an exception. {ex}");
                 }
                 else
                 {