Merge pull request #198 from divyagandhisethi/feature/k8se

Add http trigger as valid KEDA trigger type
Azure-App-Service · Apr 21, 2021 · bec1505 · bec1505
2 parents 6facc9f + 6ba128f
commit bec1505
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 3 deletions.
diff --git a/Kudu.Core/Functions/KedaFunctionTriggerProvider.cs b/Kudu.Core/Functions/KedaFunctionTriggerProvider.cs
@@ -191,6 +191,9 @@ internal static string GetKedaTriggerType(string triggerType)
                 case "rabbitmqtrigger":
                     return "rabbitmq";
 
+                case "httptrigger":
+                    return "httpTrigger";
+
                 default:
                     return string.Empty;
             }

diff --git a/Kudu.Tests/Core/Function/KedaFunctionTriggersProviderTests.cs b/Kudu.Tests/Core/Function/KedaFunctionTriggersProviderTests.cs
@@ -23,7 +23,8 @@ public void DurableFunctionApp()
                 CreateJsonFileEntry(archive, "f1/function.json", @"{""bindings"":[{""type"":""orchestrationTrigger"",""name"":""context""}],""disabled"":false}");
                 CreateJsonFileEntry(archive, "f2/function.json", @"{""bindings"":[{""type"":""entityTrigger"",""name"":""ctx""}],""disabled"":false}");
                 CreateJsonFileEntry(archive, "f3/function.json", @"{""bindings"":[{""type"":""activityTrigger"",""name"":""input""}],""disabled"":false}");
-                CreateJsonFileEntry(archive, "f4/function.json", @"{""bindings"":[{""type"":""queueTrigger"",""connection"":""AzureWebjobsStorage"",""queueName"":""queue"",""name"":""queueItem""}],""disabled"":false}");
+                CreateJsonFileEntry(archive, "f4/function.json", @"{""bindings"":[{""type"":""queueTrigger"",""connection"":""AzureWebjobsStorage"",""queueName"":""queue"",""name"":""queueItem""}],""disabled"":false}");
+                CreateJsonFileEntry(archive, "f5/function.json", @"{""bindings"":[{""type"":""httpTrigger"",""methods"":[""post""],""authLevel"":""anonymous"",""name"":""req""}],""disabled"":false}");
             }
 
             try
@@ -44,7 +45,11 @@ public void DurableFunctionApp()
 
                 ScaleTrigger queueTrigger = Assert.Single(result, trigger => trigger.Type.Equals("azure-queue", StringComparison.OrdinalIgnoreCase));
                 string functionName = Assert.Contains("functionName", queueTrigger.Metadata);
-                Assert.Equal("f4", functionName);
+                Assert.Equal("f4", functionName);
+
+                ScaleTrigger httpTrigger = Assert.Single(result, trigger => trigger.Type.Equals("httpTrigger", StringComparison.OrdinalIgnoreCase));
+                functionName = Assert.Contains("functionName", httpTrigger.Metadata);
+                Assert.Equal("f5", functionName);
             }
             finally
             {
@@ -149,7 +154,7 @@ public void PopulateMetadataDictionary_KedaV2_OnlyKedaSupportedTriggers()
             {
                 ""functionName"": ""f1"",
                 ""bindings"": [{
-                    ""type"": ""httpTrigger"",
+                    ""type"": ""eventGridTrigger"",
                     ""methods"": [""GET""],
                     ""authLevel"": ""anonymous""
                 }]