Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

only return valid keda triggers #194

Conversation

ahmelsayed
Copy link
Collaborator

No description provided.

Copy link
Collaborator

@pragnagopa pragnagopa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add unit tests.

@ahmelsayed ahmelsayed force-pushed the ahmels/fix-keda-transformation-2 branch from 3b5af74 to 827bcda Compare April 13, 2021 21:16
@ahmelsayed
Copy link
Collaborator Author

Done. I actually refactored a bit more of the code because there was another code path that was doing it's own incorrect parsing of the triggers into keda scalers.

@sanchitmehta sanchitmehta merged commit f14b10b into Azure-App-Service:feature/k8se Apr 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants