Add support for function app build by oryx #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ankitkumarr
force-pushed
the
ankikuma-func-build
branch
from
31a504f to
a3ff895
Compare
ankitkumarr
force-pushed
the
ankikuma-func-build
branch
from
a3ff895 to
1eb7af8
Compare
JennyLawrance
approved these changes
May 13, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Still need to test it, and make minor updates, but wanted feedback while I deploy and run my tests.
I tried to not touch the existing stuff much, given that we need to get this in soon. I only modified the reusable components from the existing build path.
I may also add queryparam ?build=true support after I test this stuff first.
@JennyLawrance, @ahmelsayed please have a look a this and let me know what you think.
I use the Node default as
10.14.1, not sure if that's what we use in prod right now.