Fix issues with functionapp build #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ankitkumarr
force-pushed
the
ankikuma-fix-func-build
branch
from
cdbbfc8 to
c09a530
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
\cc @JennyLawrance
We need to explicitly delete
.python_packagesto avoid issues with redeployment.Additionally, for Function Apps, FRAMEWORK and FRAMEWORK_VERSION seem to be set by the platform, but the values are not what we expect. This is because the
linuxFxVersionsetting is used very differently by a Function App. Best to not use that, until platform has a better way to indicate the right version to kudulite for Function Apps.Note: UseExpressBuild is currently not gonna work for Function App, because we try to zip up the entire directory. Maybe we need to use
WEBSITE_RUN_FROM_PACKAGE+ build settings.