[functionapp] Disable unnecessary endpoints in Linux Consumption #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Apply authorization on Deployment Logs Change authorization on the Controller level Initialize Authorization after environment injection
added 11 commits
June 7, 2019 14:32
sanchitmehta
approved these changes
Jun 13, 2019
Hazhzeng
pushed a commit
to Hazhzeng/KuduLite
that referenced
this pull request
Jul 20, 2021
…re-App-Service#52) * Filter routes for Linux Consumption KuduLite * Block zipdeploy endpoints from Linux Consumption access from IP address Apply authorization on Deployment Logs Change authorization on the Controller level Initialize Authorization after environment injection * Handle Request header disguise in middleware * Merge authentication and authorization logic in middleware * Add unit tests for authentication * Reorder using statements * Clean up using directives * Remove parallelzation for environment variable unit tests * Debug Request Not Found issue * Reorder LinuxConsumptionRouteMiddleware * Sanitize SCM Url with Regex if DISGUISED-HOST is not presented * Remove debug console log * Enable stub homepage for linux consumption
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
In Linux Consumption, we only allow three sets of endpoint
Besides that, we should seal up all other endpoints with a MiddleWare.
Solution
Implement LinuxConsumptionRouteMiddleware.cs allows a list of route prefixes to access the instance.
Activate LinuxConsumptionRouteMiddleware only when KuduLite is running in SeaBreeze containers.
Code Review Request
@balag0 @sanchitmehta