Use spx nuget package for all workflow operations, replace insecure s… #74
Conversation
|
Is there test report summary ? I am asking because it is difficult to say how the changes actually work |
This is fine for now, but long term we might want to look at a different way. For other Azure CLI tasks I have used, they use the name of a "service connection" that defines the credentials to you. Either way, I think there is something we are suppose to do at the end of our yaml file to sign out and clear these cached credentials, so that you're not left signed into Azure after your agent a release back to the agent execution pool. Refers to: .github/workflows/speech-train-data-ci-cd.yml:76 in 0ec0047. [](commit_id = 0ec0047, deletion_comment = False) |
@jhakulin For this example run I've attached the test result file |
| run: | | ||
| unzip ${{ env.TEST_ZIP_SOURCE_PATH }} -d ${{ env.TEST_BUILD_FOLDER_PATH }} | ||
| zip -r ${{ env.TEST_BUILD_FOLDER_PATH }}/${{ env.TEST_AUDIO_ZIP_FILE }} ${{ env.TEST_BUILD_FOLDER_PATH }} -x "*.txt" |
There was a problem hiding this comment.
Any idea why there was an unzip followed by zip?
There was a problem hiding this comment.
Now that I'm thinking on it, I have a vague memory of @KatieProchilo mentioning an issue during upload that was resolved by doing something similar. Katie, I know it was a while ago now.. can you recall why this is needed?
There was a problem hiding this comment.
Perhaps the old tool processes text files and audio files separately when creating a dataset? I know the new REST API takes a zip with audio files and a text file inside listing the included audio files and their transcripts for Acoustic datasets. Could be that the old REST API wanted that zip to have just audio files?
…et-env usage