Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update sample to handle app roles w/new package #74

Merged
merged 1 commit into from
Jul 13, 2020
Merged

Conversation

jennyf19
Copy link
Contributor

@jennyf19 jennyf19 commented Jul 1, 2020

in relation to this issue

nuget package will need to be updated w/the one we will release with. this is a local copy.

Copy link
Contributor

@jmprieur jmprieur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
It's way simpler

cc: @TiagoBrenck @kalyankrishna1 @Shama-K

@TiagoBrenck
Copy link
Contributor

I believe this section of the readme might have to get updated then, to match the new code.

@jennyf19
Copy link
Contributor Author

jennyf19 commented Jul 2, 2020

Thanks @TiagoBrenck i'll make sure to do that as well.

jmprieur added a commit that referenced this pull request Jul 6, 2020
This is only for testing. The right PR to merge will be #74
@jmprieur jmprieur mentioned this pull request Jul 6, 2020
jmprieur added a commit that referenced this pull request Jul 7, 2020
This is only for testing. The right PR to merge will be #74
@jennyf19 jennyf19 merged commit 24277ec into master Jul 13, 2020
@jennyf19 jennyf19 deleted the jennyf/roles branch July 13, 2020 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants