Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Frontend multi-language support #1690

Open
mrmueller opened this issue Jun 5, 2024 · 4 comments
Open

Frontend multi-language support #1690

mrmueller opened this issue Jun 5, 2024 · 4 comments
Assignees

Comments

@mrmueller
Copy link

mrmueller commented Jun 5, 2024

This issue is for a: (mark with an x)

- [ ] bug report -> please search issues before submitting
- [x] feature request
- [ ] documentation issue or request
- [ ] regression (a behavior that used to work and stopped in a new release)

Minimal steps to reproduce

The frontent is available in the English language only. We translate strings directly in the code to German.
Unfortunately this leaves behind some of our users who speak English, French or Spanish.

Expected/desired behavior

The app supports multiple languages and automatically adapts to the user's browser language.

Mention any other details that might be useful

  • We would be happy to contribute translations, are however not sure how multi-language support could be implemented in the frontend from a code perspective.
  • In a multi-language environment like we have it, we can expect the indexed documents to be in multiple languages as well.
    The creation of search terms (Backend) does not currently account for that.
@mrmueller mrmueller changed the title multi-language support Frontend multi-language support Jun 5, 2024
@pamelafox
Copy link
Collaborator

Thanks for filing, I was actually hoping to tackle this soon, so I'm glad to see there's customer interest. I am currently investigating what i18n frameworks to use on the client, I've found ngettext and i18nnext so far. Do you have any that you recommend?

@pamelafox pamelafox self-assigned this Jun 5, 2024
@mrmueller
Copy link
Author

I like to hear that @pamelafox. Unfortunately, I have zero experience in this topic. Learning about i18n frameworks right now.
Going to add one thing to the feature request:

In a multi-language environment like we have it, we can expect the indexed documents to be in multiple languages as well.
The creation of search terms does not currently account for that.

bnodir added a commit to bnodir/azure-search-openai-demo that referenced this issue Jul 7, 2024
@pamelafox
Copy link
Collaborator

Please check out the PR by @bnodir here and see if you have any thoughts on the approach:
#1790

@mrmueller
Copy link
Author

Hi @pamelafox

I like the approach for the frontend and will be happy to provide a file with German translations once this is merged.

Retrieval of multi-language content will remain a challenge. I realize that this is harder to solve though. We can create a new issue if it helps.

pamelafox added a commit that referenced this issue Aug 30, 2024
* WIP: Frontend multi-language support #1690

* WIP(2): Merge branch 'main' into multiLang

* WIP(4): Implement language switching for File Upload Feature

* Playwright fail fix

* Merge with main

* Merge fix

* Use fluent dropdown and add label to language picker

* Use string instead of String

* Pin mypy

* Reflecting changes based on review comments

* Reflecting changes based on review comments-2

* Make the language picker optional

* Fixes in docs/deploy_features.md

* Revert changes made to package-lock.json

* minor fix

* minor fix

* Playwright fail fix

* Use the language value in the API payload

* merge

---------

Co-authored-by: Pamela Fox <pamela.fox@gmail.com>
Co-authored-by: Pamela Fox <pamelafox@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants