Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Docs] Add to readme: links, getting help, load balancing #1019

Merged
merged 3 commits into from
Dec 1, 2023
Merged

[Docs] Add to readme: links, getting help, load balancing #1019

merged 3 commits into from
Dec 1, 2023

Conversation

pamelafox
Copy link
Collaborator

Purpose

This PR makes a handful of README updates:

  • Updated screenshot that says "AI search" vs "Cognitive search". @charris-msft the response changed since the last time we took it, more succinct, is okay?
  • More links to recent videos and blog posts
  • A getting help section that declares that Microsoft support doesn't support this repo.
  • As part of that, I also enabled discussions, so that we can move things into discussions that aren't real bugs. Let me know if you want to keep this repo as issues-only. The drawback is that there'll be one more place to search for answers, but the benefits are a more focused issue tracker and lower barrier for discussion-like questions.
  • Tips for load balancing OpenAI in the productionizing doc.

Does this introduce a breaking change?

[ ] Yes
[X] No

Pull Request Type

What kind of change does this Pull Request introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[X] Documentation content changes
[ ] Other... Please describe:

@pamelafox
Copy link
Collaborator Author

Fixes #1012

@charris-msft
Copy link
Collaborator

@pamelafox - I'm impressed that we got the same citations, but the response is a bit succinct... and do you know if we did anything intentionally that would have eliminated the follow-up questions? Those are a really nice feature to show.

@pamelafox
Copy link
Collaborator Author

@charris-msft Ah oops, we default to them being off in this repo, I'll turn them on for the screenshot.

@pamelafox pamelafox mentioned this pull request Nov 29, 2023
Closed
charris-msft
charris-msft approved these changes Nov 29, 2023
View reviewed changes
Copy link
Collaborator

@charris-msft charris-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LTGM - the screenshot and the text changes too.

@pamelafox pamelafox merged commit da24cf4 into Azure-Samples:main Dec 1, 2023
8 checks passed
@pamelafox pamelafox deleted the readme-tweaks branch December 1, 2023 21:22
HughRunyan pushed a commit to RMI/RMI_chatbot that referenced this pull request Mar 26, 2024
@pamelafox
[Docs] Add to readme: links, getting help, load balancing (Azure-Samp…
1f3c876 
…les#1019)

* Readme improvements

* Update screenshot and search sku message

* Dont use discussions
ratkinsoncinz pushed a commit to cinzlab/azure-search-openai-demo that referenced this pull request Oct 6, 2024
@GSLeonardo
Fix error in first question when using PF (Azure-Samples#1019)
2cfb4fb 
Co-authored-by: Leonardo Galindo Sánchez <leonardogal@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@charris-msft charris-msft charris-msft approved these changes

@chuwik chuwik Awaiting requested review from chuwik

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pamelafox @charris-msft