Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate GPT4-vision support #1056

Merged
merged 4 commits into from
Dec 13, 2023
Merged

Integrate GPT4-vision support #1056

merged 4 commits into from
Dec 13, 2023

Conversation

srbalakr
Copy link
Collaborator

@srbalakr srbalakr commented Dec 13, 2023

Purpose

This PR adds multimodal capabilities to the RAG sample by leveraging azure open ai gpt4 -vision.
Please go through docs/gpt4.md to set up and experience the capability.

Does this introduce a breaking change?

[x ] Yes
[ ] No

Pull Request Type

What kind of change does this Pull Request introduce?

[ ] Bugfix
[ x] Feature
[ ] Code style update (formatting, local variables)
[x ] Refactoring (no functional changes, no api changes)
[x ] Documentation content changes
[ ] Other... Please describe:

How to Test

  • Get the code
git clone [repo-address]
cd [repo-name]
git checkout [branch-name]
npm install
  • Test the code

What to Check

Verify that the following are valid

  • ...

Other Information

infra/core/security/keyvault.bicep Dismissed Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@pamelafox
Copy link
Collaborator

To get 3.9 CI happy, change this line in .github/workflows/python-test.yaml

run: python3 -m pytest -s -vv --cov --cov-fail-under=87

to =86

I didn't quite get coverage back up to 87% :(

Copy link
Collaborator

@pamelafox pamelafox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks as expected now. I can do another test azd up or you can merge now, depending when you need it live.

@srbalakr
Copy link
Collaborator Author

Looks as expected now. I can do another test azd up or you can merge now, depending when you need it live.

I did a fresh azd up on Aust East and swiss nor. Looking good. Will merge it in sometime.

@pamelafox
Copy link
Collaborator

Sigh am not sure why GitHub decided not to run the checks on the last commit, I had that problem earlier today with another repo. Tests now pass locally.

@srbalakr srbalakr merged commit 3601589 into main Dec 13, 2023
1 check passed
HughRunyan pushed a commit to RMI/RMI_chatbot that referenced this pull request Mar 26, 2024
* Squash commit# This is a combination of 3 commits.

add new files

s

remove

* s

* s

* Add one more conditional to Bicep, and fix the mocks to use vector_queries

---------

Co-authored-by: Pamela Fox <pamela.fox@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants