[BugFix] Fix logic in prepdocs to always update search index #1066
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pamelafox
changed the title
pamelafox
commented
Dec 14, 2023
| @@ -180,13 +180,8 @@ def __init__( | |||
| self.credential = credential | |||
| self.organization = organization | |||
|
|
|||
| async def create_embedding_arguments(self) -> dict[str, Any]: | |||
There was a problem hiding this comment.
This was another change in Shakirs PR that looks like a bad merge, so I reverted it to what was in main.
srbalakr
approved these changes
Dec 14, 2023
|
Thanks for fixing this! |
HughRunyan
pushed a commit
to RMI/RMI_chatbot
that referenced
this pull request
Mar 26, 2024
…amples#1066) * Fix indetation to update index * Bring back create_client
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Fixes #1063
I think this line of code was accidentally indented.
Does this introduce a breaking change?
Pull Request Type
What kind of change does this Pull Request introduce?
How to Test
Splitting 'role_library.pdf' into sections
Uploading blob for whole file -> role_library.pdf
Batch Completed. Batch size 16 Token count 3246
Batch Completed. Batch size 16 Token count 3167
Batch Completed. Batch size 16 Token count 3201
Batch Completed. Batch size 10 Token count 1949