Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename OneShot to Ask, update Black style #1191

Merged
merged 3 commits into from
Jan 26, 2024
Merged

Rename OneShot to Ask, update Black style #1191

merged 3 commits into from
Jan 26, 2024

Conversation

pamelafox
Copy link
Collaborator

Purpose

This PR changes "OneShot" to "Ask", to match its UI title. With the current naming, its harder for developers to find the right file, and its misleading since we actually use a "few-shot" technique in aspects of the "Ask" approach. A more correct term would be "Multi-turn" for "Chat" and "Single-turn" for "Ask, but I don't want to rename "Chat" as well.

The drawback of this change is that it may be an annoying merge for existing developers who have customized those files, so you can decide if it's worth it for clarity going forwards.

Does this introduce a breaking change?

[ ] Yes
[X] No

Pull Request Type

What kind of change does this Pull Request introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[X] Refactoring (no functional changes, no api changes)
[ ] Documentation content changes
[ ] Other... Please describe:

How to Test

  • Start up the UI, ask a question, open up the dev settings

@pamelafox pamelafox changed the title Rename OneShot to Ask Rename OneShot to Ask, update Black style Jan 26, 2024
@mattgotteiner
Copy link
Collaborator

thanks for fixing black

@pamelafox pamelafox merged commit 8048b28 into Azure-Samples:main Jan 26, 2024
10 checks passed
@pamelafox pamelafox deleted the oneshotask branch January 26, 2024 19:46
HughRunyan pushed a commit to RMI/RMI_chatbot that referenced this pull request Mar 26, 2024
* Rename OneShot to Ask

* Formatting changes from new black version
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants