Use AVM for log analytics and application insights. #1817
Conversation
| name: 'loganalytics' | ||
| params: { | ||
| name: logAnalyticsName | ||
| location: location | ||
| tags: tags | ||
| skuName: 'PerGB2018' | ||
| dataRetention: 30 | ||
| publicNetworkAccessForIngestion: publicNetworkAccess |
There was a problem hiding this comment.
I'm surprised that the avm has a parameter named publicNetworkAccessForIngestion ? How is that working?
There was a problem hiding this comment.
It's a parameter of the log analytics workspace and the application insights account anyway https://github.com/Azure/bicep-registry-modules/blob/main/avm/res/operational-insights/workspace/main.bicep#L192-L193
There was a problem hiding this comment.
Ohh, I thought it was one we made up ("ingestion" threw me off). Got it, thanks
|
Which envs have you tested with, both public and vnet? I want to figure out what still needs testing. |
|
After doing a diff on the deployment, the only thing this changes is |
|
Okay, thanks for diff'ing! @mattgotteiner This will be the first move to AVM but the hope is to move all modules to AVM, to reduce Bicep modules in our code and inherit best practices by default from AVM. |
Provisions the same resources but using the AVM resources. Replaces the 2 custom bicep files that existed for provisioning the resources with the custom private network flag.