Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update deploy_features.md #1885

Merged
merged 9 commits into from
Aug 6, 2024
Merged

Conversation

YIN-Renlong
Copy link
Contributor

Purpose

Added detailed instructions for setting up GPT-4 and GPT-4o deployments. Included specific commands for deployment names, model versions, and deployment capacities. Clarified steps for setting deployment capacity with a note on default values for GPT-4o.

Does this introduce a breaking change?

When developers merge from main and run the server, azd up, or azd deploy, will this produce an error?
If you're not sure, try it out on an old environment.

[ ] Yes
[x] No

Does this require changes to learn.microsoft.com docs?

This repository is referenced by this tutorial
which includes deployment, settings and usage instructions. If text or screenshot need to change in the tutorial,
check the box below and notify the tutorial author. A Microsoft employee can do this for you if you're an external contributor.

[ ] Yes
[x] No

Type of change

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[x] Documentation content changes
[ ] Other... Please describe:

Code quality checklist

See CONTRIBUTING.md for more details.

  • The current tests all pass (python -m pytest).
  • I added tests that prove my fix is effective or that my feature works
  • I ran python -m pytest --cov to verify 100% coverage of added lines
  • I ran python -m mypy to check for type errors
  • I either used the pre-commit hooks or ran ruff and black manually on my code.

Added detailed instructions for setting up GPT-4 and GPT-4o deployments. Included specific commands for deployment names, model versions, and deployment capacities. Clarified steps for setting deployment capacity with a note on default values for GPT-4o.
@YIN-Renlong
Copy link
Contributor Author

YIN-Renlong commented Aug 4, 2024

@microsoft-github-policy-service agree

docs/deploy_features.md Outdated Show resolved Hide resolved
docs/deploy_features.md Outdated Show resolved Hide resolved
docs/deploy_features.md Outdated Show resolved Hide resolved
docs/deploy_features.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@pamelafox pamelafox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much! Would love if you could add -mini instructions while you're in this file.

Hi @pamelafox, I have made the suggested changes, including adding instructions for the -mini model. Please review the updated file. Thanks!
@YIN-Renlong
Copy link
Contributor Author

Thanks so much! Would love if you could add -mini instructions while you're in this file.

Hi @pamelafox, thanks. I have made the suggested changes, including adding instructions for the -mini model. Please review the updated file. Thanks!

docs/deploy_features.md Outdated Show resolved Hide resolved
@pamelafox
Copy link
Collaborator

The markdownlint checker isn't happy. The markdown extension will auto-fix it locally, I can do it locally once I'm done testing another branch, or you can do it yourself. (My attempts to fix via GitHub suggestions were not fruitful)

This update corrects various markdown formatting issues to comply with markdownlint standards.
Copy link
Contributor Author

@YIN-Renlong YIN-Renlong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The markdownlint checker isn't happy. The markdown extension will auto-fix it locally, I can do it locally once I'm done testing another branch, or you can do it yourself. (My attempts to fix via GitHub suggestions were not fruitful)

Hi @pamelafox, thanks for the heads-up! I've fixed the markdown format according to the markdownlint checker requirements. (I accidentally closed the pull request but have now reopened it.)

@YIN-Renlong
Copy link
Contributor Author

YIN-Renlong commented Aug 6, 2024

@YIN-Renlong YIN-Renlong closed this Aug 6, 2024
@YIN-Renlong YIN-Renlong reopened this Aug 6, 2024
@pamelafox pamelafox merged commit 27816c1 into Azure-Samples:main Aug 6, 2024
8 checks passed
@pamelafox
Copy link
Collaborator

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants