Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 3.8 and 3.9 to test to matrix, fix type bug #454

Merged
merged 1 commit into from
Jul 26, 2023
Merged

Add 3.8 and 3.9 to test to matrix, fix type bug #454

merged 1 commit into from
Jul 26, 2023

Conversation

pamelafox
Copy link
Collaborator

Purpose

Apparently some developers are using Python 3.8 to run this code, so we should run tests on 3.8 and 3.9 as well. This PR adds them to the test matrix and fixes a typing related issue.

Does this introduce a breaking change?

[ ] Yes
[X] No

Pull Request Type

What kind of change does this Pull Request introduce?

[X] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Documentation content changes
[ ] Other... Please describe:

How to Test

  • Wait for tests to pass! :)

@pamelafox pamelafox requested a review from chuwik July 24, 2023 21:21
@pamelafox pamelafox merged commit ae062da into Azure-Samples:main Jul 26, 2023
6 checks passed
@pamelafox pamelafox deleted the python38 branch July 26, 2023 21:05
HughRunyan pushed a commit to RMI/RMI_chatbot that referenced this pull request Mar 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants