Add application insights for request and backend tracing of performance data #515
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… a different order
pamelafox
requested changes
Aug 9, 2023
Co-authored-by: Pamela Fox <pamela.fox@gmail.com>
pamelafox
approved these changes
Aug 9, 2023
|
Please update to ASGI goodness |
|
@chuwik suggests making it opt in, like a USE_OPENTELEMETRY or USE_APPINSIGHTS parameter perhaps? |
pamelafox
reviewed
Aug 10, 2023
| @@ -55,6 +55,9 @@ | |||
| }, | |||
| "gptDeploymentName": { | |||
| "value": "${AZURE_OPENAI_GPT_DEPLOYMENT=davinci}" | |||
| }, | |||
| "useApplicationInsights": { | |||
| "value": "${AZURE_USE_APPLICATION_INSIGHTS=false}" | |||
There was a problem hiding this comment.
I notice the TODO templates also output the similar USE_APIM in main.bicep - am not sure when/if thats needed for this scenario: https://github.com/pamelafox/azure-dev/blob/37f88d5196a3aed4899f2928a67f43714dbff967/templates/todo/projects/csharp-sql/.repo/bicep/infra/main.bicep#L200
If you're not sure either, maybe @vhvb1989 can chime in.
pamelafox
reviewed
Aug 10, 2023
pamelafox
approved these changes
Aug 10, 2023
This was referenced Aug 15, 2023
Add OpenCensus or OpenTelemetry (possibly optionally) - FastAPI
kjaymiller/cookiecutter-relecloud#34
Open
HughRunyan
pushed a commit
to RMI/RMI_chatbot
that referenced
this pull request
Mar 26, 2024
…ce data (Azure-Samples#515) * Example for request and backend tracing * Add bicep for an application insights service connected to the backend * Quart draft * Loosen requirements * Use the new azure package for OTEL * Remove rich console import * Fix ask and test * Quart deploying now * Use semantic * Get tests working * Output connection string for azure monitor. Enable instrumentation in a different order * Revert simple * Typing fixes * dont use pipe * Simplify tracing setup * Exclude app insights from output strings * Reorder imports * Only configure azure monitor if environment variable is set * Update app/backend/app.py Co-authored-by: Pamela Fox <pamela.fox@gmail.com> * Fix import paths for aio * Make Application Insights optional, add documentation * Reorder imports * Pin versions * Trace aiohttp calls * reorder imports --------- Co-authored-by: Pamela Fox <pamela.fox@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Application Insights
This PR adds Application Insights with tracing and logging in the app using Open Telemetry
End-to-End tracing of chat requests
Admins can see the trace of any HTTP request including all backend calls to Cognitive Search and Open AI APIs.
Exceptions captured and logged
Server-side exceptions are now logged and available in the Failures page