Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address recent bugs #529

Merged
merged 3 commits into from
Aug 15, 2023
Merged

Address recent bugs #529

merged 3 commits into from
Aug 15, 2023

Conversation

srbalakr
Copy link
Collaborator

@srbalakr srbalakr commented Aug 11, 2023

Purpose

This PR address some of the recent bugs

  1. Users experience 401 during index build.
    • Refresh token every 5 minutes for open ai calls
  2. Suggestion prompt does not work
    • Gpt turbo do not handle lengthy system prompts. Moved document sources to user conversation

Does this introduce a breaking change?

[ ] Yes
[x ] No

Pull Request Type

What kind of change does this Pull Request introduce?

[ x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Documentation content changes
[ ] Other... Please describe:

How to Test

  • Get the code
git clone [repo-address]
cd [repo-name]
git checkout [branch-name]
npm install
  • Test the code

What to Check

Verify that the following are valid

  • ...

Other Information

scripts/prepdocs.py Outdated Show resolved Hide resolved
scripts/prepdocs.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@pamelafox pamelafox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the future, I think it'd be nice to send unrelated bug fixes in two different PRs. That makes it easy to patch or revert single fixes as needed. Thanks!

Copy link
Collaborator

@pamelafox pamelafox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, I stepped through the time logic with my partner, it does work - I was flipping the times in my head.

@srbalakr srbalakr merged commit cf3a348 into main Aug 15, 2023
4 checks passed
HughRunyan pushed a commit to RMI/RMI_chatbot that referenced this pull request Mar 26, 2024
* s

* comments

* address comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants