Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md with logging info #610

Merged
merged 2 commits into from
Sep 8, 2023
Merged

Update README.md with logging info #610

merged 2 commits into from
Sep 8, 2023

Conversation

pamelafox
Copy link
Collaborator

Purpose

This PR adds details on how to use logs both locally and in App Service. People need this for debugging issues, its coming up a lot on issues. I made a little video to help as well.

Does this introduce a breaking change?

[ ] Yes
[X] No

Pull Request Type

What kind of change does this Pull Request introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[X] Documentation content changes
[ ] Other... Please describe:

README.md Outdated
To log additional things, first set the level of logs you want to see by writing this code inside the `create_app()` function in `app.py`:

```python
logging.basicConfig(level=logging.INFO)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should make this an environment variable

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah thats a good idea, so we could always have this line in the code? love it.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done, checked on App Service with multiple levels, updated FAQ.

@pamelafox pamelafox merged commit de2f451 into main Sep 8, 2023
6 checks passed
HughRunyan pushed a commit to RMI/RMI_chatbot that referenced this pull request Mar 26, 2024
* Update README.md with logging info

* Build logging in with env var
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants