Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for paths with spaces #71

Merged
merged 2 commits into from
Jul 24, 2023
Merged

Fix for paths with spaces #71

merged 2 commits into from
Jul 24, 2023

Conversation

amithkk
Copy link
Contributor

@amithkk amithkk commented Mar 30, 2023 •
edited
Loading

Purpose

Does this introduce a breaking change?

[ ] Yes
[x] No

Pull Request Type

What kind of change does this Pull Request introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Documentation content changes
[ ] Other... Please describe:

itsamk
itsamk approved these changes Apr 9, 2023
View reviewed changes
Copy link

@itsamk itsamk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The solution is correct. Verified on my environment.

fdezdaniel
fdezdaniel reviewed Apr 11, 2023
View reviewed changes
Copy link

@fdezdaniel fdezdaniel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had same issue described here (#70) and I reached to the same fix than amithkk proposed. I confirm it works in my environment. It is needed to quote $cwd variable

@amithkk
Copy link
Contributor Author

amithkk commented May 8, 2023

Any updates on this pull request?
@chuwik - perhaps you can take a quick look?

pamelafox
pamelafox approved these changes Jul 24, 2023
View reviewed changes
Copy link
Collaborator

@pamelafox pamelafox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to work, thanks for the PR!

@pamelafox pamelafox merged commit 664abbd into Azure-Samples:main Jul 24, 2023
4 checks passed
@pamelafox pamelafox mentioned this pull request Jul 24, 2023
Closed
HughRunyan pushed a commit to RMI/RMI_chatbot that referenced this pull request Mar 26, 2024
@amithkk @pamelafox
Fix for paths with spaces (Azure-Samples#71)
c224ef8 
Co-authored-by: Pamela Fox <pamela.fox@gmail.com>
ManishBastola pushed a commit to RMI/RMI_chatbot that referenced this pull request Aug 13, 2024
@pamelafox
Merge pull request Azure-Samples#71 from Azure-Samples/pipeline
9a84204 
Fixes for running on GH
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@itsamk itsamk itsamk approved these changes

@fdezdaniel fdezdaniel fdezdaniel approved these changes

@pamelafox pamelafox pamelafox approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Postprovision hook fails if repository is cloned to a path containing spaces
4 participants
@amithkk @pamelafox @fdezdaniel @itsamk