Changes to simulator usage #135
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ex and use model_config for the latest version of the simulator
nagkumar91
changed the title
kdestin
approved these changes
Oct 17, 2024
diondrapeck
reviewed
Oct 17, 2024
| "metadata": {}, | ||
| "outputs": [], | ||
| "source": [ | ||
| "os.environ[\"AZURE_OPENAI_API_KEY\"] = \"<your-api-key>\"\n", |
There was a problem hiding this comment.
Can we move this section up to the Parameters cell and then reference the environment variables throughout instead of setting those values explicitly in the Parameters cell and then having this section below?
Then, users can know to set all of their environment variables and then run the notebook from there without any other configuration in later steps.
There was a problem hiding this comment.
@slister1001 will address this in her PR - #138
I'm abandoning this PR once she has all the components from here included in hers
w-javed
reviewed
Oct 17, 2024
| { | ||
| "content": "Here is my follow-up question.", | ||
| "user": "user" | ||
| } |
There was a problem hiding this comment.
Should it be ?
"role": "user"
There was a problem hiding this comment.
Good catch. Posting on #138
|
LGTM, just a minor comment. |
w-javed
approved these changes
Oct 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Checklist