Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating/work-with this template for GHA and Azd Devcontainer feature. #24

Closed
zedy-wj opened this issue Jul 28, 2023 · 1 comment · Fixed by #28
Closed

Updating/work-with this template for GHA and Azd Devcontainer feature. #24

zedy-wj opened this issue Jul 28, 2023 · 1 comment · Fixed by #28

Comments

@zedy-wj
Copy link

zedy-wj commented Jul 28, 2023

Please provide us with the following information:

This issue is for a: (mark with an x)

- [ ] bug report -> please search issues before submitting
- [x] feature request
- [ ] documentation issue or request
- [ ] regression (a behavior that used to work and stopped in a new release)

We are updating this template to support new features in Github Action and Azd Devcontainer.

  1. For the Github Action feature: We will remove two lines of code on container image and add GHA code after checkout step in the .github/workflow/azure-dev.yml file. (Shown as below)
image
  1. For the Azd Devcontainer feature: We will add the following code in devcontainer.json file.
"ghcr.io/azure/azure-dev/azd:latest": {}

And remove the relevant code for installing azd in Dockerfile under .devcontainer folder.

RUN curl -fsSL https://aka.ms/install-azd.sh | bash \

@rajeshkamal5050 , @pamelafox , @shreyabatra4 for notification.

@pamelafox
Copy link
Contributor

FYI, I added azd feature in this PR here:
#23

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants