Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updating/work-with community templates for GHA and Azd Devcontainer feature #2509

Open
rajeshkamal5050 opened this issue Jul 11, 2023 · 14 comments
Open

Updating/work-with community templates for GHA and Azd Devcontainer feature #2509

rajeshkamal5050 opened this issue Jul 11, 2023 · 14 comments
Assignees
@v-xuto
Labels
devcontainer github actions templates
Milestone
Backlog

Comments

@rajeshkamal5050
Copy link
Contributor

No description provided.

@rajeshkamal5050 rajeshkamal5050 added this to the August 2023 - 1.2.0 milestone Jul 11, 2023
@v-xuto
Copy link
Member

v-xuto commented Jul 12, 2023

@rajeshkamal5050 What are the community templates?
Create a PR to support GHA and Azd Devcontainer features for community templates? If not, please provide more information about this issue.

@rajeshkamal5050
Copy link
Contributor Author

Similar to how we converted our todo templates to use GHA action and Azd DevContainer features.

We need the community samples https://azure.github.io/awesome-azd/ to also adopt the same. To start with, we can

  • File issue on the respective community template repos to adopt them.
  • Pickup simpler and easily testable templates and start to convert.

@ellismg @savannahostrowski does that sound okay?

@savannahostrowski
Copy link

We are planning on doing this for all templates on awesome-azd right? Or are we also considering filing issues on all templates found in https://github.com/topics/azd-templates?

@rajeshkamal5050
Copy link
Contributor Author

We are planning on doing this for all templates on awesome-azd right? Or are we also considering filing issues on all templates found in https://github.com/topics/azd-templates?

Yes, for all templates. Since there are around 40+ community templates. We will start filing issues on the respective repos pointing to our todo template changes for GHA action and Azd DevContainer features. Will be helpful for respective owners who can make the changes themselves.

Also, manual testing team will start making changes to some of the templates and help the community for any questions.

@savannahostrowski
Copy link

That makes sense. We should also probably notify the authors of the Microsoft-authored templates as well. Looks like 80 repos on azd-templates topic.

@v-xuto
Copy link
Member

v-xuto commented Jul 21, 2023

@rajeshkamal5050 We have filed a community sample issue from https://azure.github.io/awesome-azd/, please review.

If there is no problem, we will check the remaining community samples and file issues.
Once the authors adopt these issues, we will start to convert.

In addition, do the samples in https://github.com/topics/azd-templates also need to add the GHA and Azd Devcontainer feature?

@rajeshkamal5050
Copy link
Contributor Author

rajeshkamal5050 commented Jul 24, 2023 •
edited
Loading

@rajeshkamal5050 We have filed a community sample issue from https://azure.github.io/awesome-azd/, please review.

@v-xuto LGTM.

In addition, do the samples in https://github.com/topics/azd-templates also need to add the GHA and Azd Devcontainer feature?

Yes.

@v-xuto
Copy link
Member

v-xuto commented Jul 28, 2023 •
edited
Loading

@rajeshkamal5050 About this link https://azure.github.io/awesome-azd/, we have checked all 57 templates, and filed 32 issues to add GHA and Azd Devcontainer feature. Please review, if there is no question, please add relevant approval comments, and we will start to modify and create PR. The following are the issues/templates:

  1. Add GHA and Azd Devcontainer feature issues:
    Updating/work-with this template for GHA and Azd Devcontainer feature. reliable-web-app-pattern-dotnet#329
    Updating/work-with this template for GHA and Azd Devcontainer feature. rpothin/servicebus-csharp-function-dataverse#6
    Updating/work-with this template for GHA and Azd Devcontainer feature. Azure-Samples/azure-django-postgres-flexible-aca#52
    Updating/work-with this template for GHA and Azd Devcontainer feature. Azure-Samples/openai-plugin-fastapi#8
    Updating/work-with this template for GHA and Azd Devcontainer feature.  bradygaster/RockPaperOrleans#13
    Updating/work-with this template for GHA and Azd Devcontainer feature.  sabbour/aks-app-template#1
    Updating/work-with this template for GHA and Azd Devcontainer feature. Gordonby/servicebus-dotnet-functionapp#7
    Updating/work-with this template for GHA and Azd Devcontainer feature. Azure-Samples/ASA-Samples-Event-Driven-Application#15
    Updating/work-with this template for GHA and Azd Devcontainer feature. Azure-Samples/fastapi-on-azure-functions#24
    Updating/work-with this template for GHA and Azd Devcontainer feature. Azure-Samples/contoso-real-estate#239

  2. Only add GHA feature issues:

  1. Only add Azd Devcontainer feature issues:
  1. No need to add GHA and Azd Devcontainer feature in the following templates:
  1. One template can't open, it's error is Page not found. The description of this template is Azure Health Data Services Toolkit Azure Function Quickstart. Please help confirm.

@v-xuto
Copy link
Member

v-xuto commented Aug 29, 2023

@rajeshkamal5050 About this link https://github.com/topics/azd-templates, we have checked all 84 templates, and filed 22 new issues to add GHA and Azd Devcontainer feature. Please review, if there is no question, please add relevant approval comments, and we will start to modify and create PR. The following are the issues/templates:

  1. Add GHA and Azd Devcontainer feature issues:
    Updating/work-with this template for GHA and Azd Devcontainer feature. bradygaster/dotnet-redis-pubsub#5
    Updating/work-with this template for GHA and Azd Devcontainer feature. rpothin/servicebus-csharp-function-dataverse#7
    Updating/work-with this template for GHA and Azd Devcontainer feature.  pamelafox/msdocs-django-postgresql-sample-app#7
    Updating/work-with this template for GHA and Azd Devcontainer feature savannahostrowski/savannah.dev#5
    Updating/work-with this template for GHA and Azd Devcontainer feature lechnerc77/azd-compatibility-azure-function#2
    Updating/work-with this template for GHA and Azd Devcontainer feature NikiforovAll/azd-webapi#3
    Updating/work-with this template for GHA and Azd Devcontainer feature. manekinekko/todo-nodejs-mongo-swa#4
    Updating/work-with this template for GHA and Azd Devcontainer feature. crazy4pi314/littlest-jupyterhub-vm#1
    Updating/work-with this template for GHA and Azd Devcontainer feature. sjkp/deno-azd-template#2
    Updating/work-with this template for GHA and Azd Devcontainer feature. zul-m/AzureDevCLI#2
    Updating/work-with this template for GHA and Azd Devcontainer feature. fangjian0423/todo-java-postgresql-aca-terraform#4
    Updating/work-with this template for GHA and Azd Devcontainer feature. atrakic/fastapi-htmx-azd-template#7

  2. Only add GHA feature issues:

  1. Only add Azd Devcontainer feature issues:
  1. No need to add GHA and Azd Devcontainer feature in the following templates:

  1. Here are 23 duplicate templates that have created issues in link https://azure.github.io/awesome-azd/.

  2. We cannot create an issue for this template. See the figure below for details. Please review and help resolve.
    https://github.com/puicchan/app-templates-integration-services
    image

@v-xuto
Copy link
Member

v-xuto commented Sep 14, 2023

@rajeshkamal5050 About the community templates in links https://azure.github.io/awesome-azd/ and https://github.com/topics/azd-templates, we have checked all templates, and filed 54 issues to add GHA and Azd Devcontainer feature. Please help review these issues.

Do we need to create PRs for these issues? If yes, please add relevant approval comments in the corresponding issues, and we will start to create PRs to fix them.

@rajeshkamal5050
Copy link
Contributor Author

rajeshkamal5050 commented Sep 19, 2023 •
edited
Loading

Do we need to create PRs for these issues? If yes, please add relevant approval comments in the corresponding issues, and we will start to create PRs to fix them.

Its hard to make changes, test them for all repos. Instead, do changes for a couple of templates, provide them as reference changes on the filed issues. So the respective repo owners can make changes themselves.

@v-xuto
Copy link
Member

v-xuto commented Sep 25, 2023

@rajeshkamal5050 We have completed changes about two templates, provide them as reference changes on the filed issues.
Please review the following PRs.

@bobtabor-msft
Copy link

bobtabor-msft commented Dec 14, 2023 •
edited
Loading

Do we need to create PRs for these issues? If yes, please add relevant approval comments in the corresponding issues, and we will start to create PRs to fix them.

Its hard to make changes, test them for all repos. Instead, do changes for a couple of templates, provide them as reference changes on the filed issues. So the respective repo owners can make changes themselves.

Is there documentation on what this feature is, why it was introduced, what it hopes to achieve, and guidance on how to make the change without breaking anything else? Many of the repo owners (well, just me) are still trying to get our sea legs under us with all of this azd stuff, and have inherited these repos and are several generations removed from the original creators. Thank you in advance for any help / documentation (!!!) / guidance you can provide.

cc: rajeshkamal5050

@vhvb1989
Copy link
Member

@bobtabor-msft the gh-action and gh-devcontainer features where announced on July-release, see: https://devblogs.microsoft.com/azure-sdk/azure-developer-cli-azd-july-2023-release/#azd-as-a-github-action

There's a summary about why we introduced this feature and how to use it.

Let me know if it answers your questions.

@rajeshkamal5050 rajeshkamal5050 removed this from the Germanium milestone Mar 12, 2024
@rajeshkamal5050 rajeshkamal5050 added this to the Backlog milestone Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@v-xuto v-xuto

Labels
devcontainer github actions templates
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
5 participants
@savannahostrowski @rajeshkamal5050 @vhvb1989 @bobtabor-msft @v-xuto