Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: observabiltiy-as-code #479

Merged
merged 7 commits into from
Mar 29, 2022
Merged

feat: observabiltiy-as-code #479

merged 7 commits into from
Mar 29, 2022

Conversation

sudivate
Copy link
Contributor

@sudivate sudivate commented Feb 5, 2022

Type of PR

  • Code changes
  • Documentation changes

Purpose

  • Enhanced Observability by adding below resources for Observability-as-code in Bicep modules
    • Azure Dashboard to monitor key metrics from Azure Data Factory and Azure SQL Server
    • Azure Log Analytics Workspace to collect monitoring Data
    • Enabled diagnostic settings for Azure Data Factory
    • Azure Monitor alert for Azure Data Factory Pipelines
  • Demonstrated Data Quality monitoring using OSS Great Expectations in Standardize and Transformation steps of Data pipeline
  • Sample Data Quality Azure Monitor workbook
  • Updated Docs relevant to all above changes

Does this introduce a breaking change? If yes, details on what can break

Author pre-publish checklist

  • Added test to prove my fix is effective or new feature works
  • No PII in logs
  • Made corresponding changes to the documentation

@sudivate sudivate requested a review from devlace February 5, 2022 03:16
@devlace
Copy link
Contributor

devlace commented Mar 23, 2022

Updated the .NET version to 4.7 to resolve build error

@devlace
Copy link
Contributor

devlace commented Mar 28, 2022

@sudivate Running into an error in the Databricks notebook.
image
Looks like its related to a recent breaking change on jinja's side: pallets/jinja#1626

@sudivate sudivate merged commit 6956c7e into Azure-Samples:main Mar 29, 2022
@sudivate
Copy link
Contributor Author

Thank you @devlace.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants