Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

API bug fix + doco update #719

Merged
merged 4 commits into from
Jul 2, 2024
Merged

API bug fix + doco update #719

merged 4 commits into from
Jul 2, 2024

Conversation

promisinganuj
Copy link
Contributor

Type of PR

  • Documentation changes
  • Code changes

Purpose

  • Fixing Workspace assignment bug because of a change in the API response.
  • Updating the doco.
  • ...

Does this introduce a breaking change? If yes, details on what can break

No

Author pre-publish checklist

  • Added test to prove my fix is effective or new feature works
  • No PII in logs
  • Made corresponding changes to the documentation

Validation steps

  • Review the README.md
  • Test the bootstrap script

Issues Closed or Referenced

@promisinganuj promisinganuj added the bug Something isn't working label Jun 26, 2024
@promisinganuj promisinganuj self-assigned this Jun 26, 2024
@promisinganuj promisinganuj linked an issue Jun 26, 2024 that may be closed by this pull request
Bug Fix (API response change) + Documentation Update #718
Closed
sreedhar-guda
sreedhar-guda approved these changes Jun 26, 2024
View reviewed changes
Copy link
Contributor

@sreedhar-guda sreedhar-guda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving with some minor comments. Feel free to merge after making changes.

single_tech_samples/fabric/fabric_ci_cd/README.md Show resolved Hide resolved
single_tech_samples/fabric/fabric_ci_cd/README.md Outdated Show resolved Hide resolved
ydaponte
ydaponte approved these changes Jun 27, 2024
View reviewed changes
Copy link
Contributor

@ydaponte ydaponte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great review from @sreedhar-guda - nothing to add!

@promisinganuj promisinganuj merged commit 12df1fd into main Jul 2, 2024
4 checks passed
@promisinganuj promisinganuj deleted the anujparashar/718-bug-fix-readme-updates branch July 2, 2024 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sreedhar-guda sreedhar-guda sreedhar-guda approved these changes

@ydaponte ydaponte ydaponte approved these changes

Assignees

@promisinganuj promisinganuj

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug Fix (API response change) + Documentation Update
3 participants
@promisinganuj @sreedhar-guda @ydaponte