This repository has been archived by the owner on Feb 8, 2024. It is now read-only.
[WIP]Updates for MSAL 0.4 #22
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -30,8 +30,8 @@ | |||
|
|
|||
| <!--Add in your scheme/host from registered redirect URI--> | |||
| <data android:scheme="msauth" | |||
| android:host= "YOUR_PACKAGE_NAME - must be registered at https://aka.ms/MobileAppReg" | |||
| android:path= "/YOUR_DECODED_SIGNATURE_HASH - must be registered at https://aka.ms/MobileAppReg>" /> | |||
| android:host= "com.azuresamples.msalandroidapp" | |||
There was a problem hiding this comment.
I think it was on purpose to keep it in this way.
android:host= "YOUR_PACKAGE_NAME - must be registered at https://aka.ms/MobileAppReg"
android:path= "/YOUR_DECODED_SIGNATURE_HASH - must be registered at https://aka.ms/MobileAppReg>" />
There was a problem hiding this comment.
Yes. I'll put back the original values... prior to actually merging. Leaving it this way for testing.
iambmelt
reviewed
Jun 28, 2019
| } | ||
|
|
||
| dependencies { | ||
| implementation project(':msal') |
There was a problem hiding this comment.
What's the plan around using this value vs loading from Maven central?
iambmelt
reviewed
Jun 28, 2019
|
|
||
| @Override | ||
| public void onError(@NonNull Exception exception) { | ||
|
|
There was a problem hiding this comment.
We should show a Toast or dialog if this error gets hit - otherwise, users of the samples might be confused with a silent failure
iambmelt
reviewed
Jun 28, 2019
|
|
||
| @Override | ||
| public void onError(@NonNull MsalException exception) { | ||
|
|
There was a problem hiding this comment.
Same feedback here regarding a Toast or dialog
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.