This repository has been archived by the owner on Jun 12, 2024. It is now read-only.
Updating to MSAL.NET 4.16 #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmprieur
requested review from
kalyankrishna1,
bgavrilMS,
TiagoBrenck and
jennyf19
jmprieur
commented
Jul 6, 2020
| // if the access operation resulted in a cache update | ||
| if (args.HasStateChanged) | ||
| { | ||
| string cacheKey = GetMsalAccountId(); | ||
| string cacheKey = args.SuggestedCacheKey ?? args.Account?.HomeAccountId?.Identifier; |
There was a problem hiding this comment.
Workaround to a current bug in MSAL.NET that @bgavrilMS is fixing.
jmprieur
commented
Jul 6, 2020
| string cacheKey = GetMsalAccountId(); | ||
|
|
||
| if (string.IsNullOrWhiteSpace(cacheKey)) | ||
| string cacheKey = args.SuggestedCacheKey ?? args.Account?.HomeAccountId?.Identifier; |
There was a problem hiding this comment.
Workaround to a current bug in MSAL.NET that @bgavrilMS is fixing.
neha-bhargava
approved these changes
Jul 7, 2020
jennyf19
approved these changes
Jul 7, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updating to MSAL.NET 4.16
SuggestedCacheKeyofTokenCacheNotificationArgsas the cache keyHasTokensofTokenCacheNotificationArgsto remove the record corresponding to the user when there are no longer any token in the cache for the user (after signout)