-
Notifications
You must be signed in to change notification settings - Fork 26
chore: update resource API versions and improve naming conventions #37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Co-authored-by: Chad Kittel <chad.kittel@gmail.com>
…ng conventions
…esources
…hanced functionality
Deployment was tested here: https://github.com/Azure/data-ai-solutions-lab/actions/runs/14254281437/job/39953877367 ![]() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
.
…ecurity and management
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for updating API versions and applying some formatting changes.
Before I merge, I'll wait to hear from @segraef -- as he let me know that the latest test had a failure due to something related to a network monitor in Australia east.
Hey @ckittel I just made another test-run in westus, eastus and a couple of other regions to identify the property/setting which causes the new network monitor enablement. Just for understanding, I'm using the same properties you want me to remain with the new api versions what's causing this.
Testing is very time-intensive since I everytime I do a full e2e deployment which takes about 1h since the aoai workspaces need to be purged before another deployment can run but also to have a full e2e testing done properly since this is an Azure-Sample which should work for anyone else consuming it. I'll give it a couple of more tries now, otherwise I'm going to close this PR due to my constrained capacity, sorry for that mate. |
Okay, I have a working version using ![]() These properties were brought back in
For now I'm going to close this PR until a more stable version is being published or you accept my initial PR which brought in a state at |
Thank you. We've got almost all of these applied now via the other recent PRs (#42, #43, #44) that used your PR as inspiration. The only one we skipped (for now) is App Service. We plan on revisiting that soon, also not going to apply the role assignment one or the couple of formatting tweaks. We might pick the formatting tweaks up in a future PR. So, we'll close this one as mostly applied. Once again, thank you! <3 |
Purpose
Does this introduce a breaking change?
Pull Request Type
What kind of change does this Pull Request introduce?
How to Test
What to Check
Verify that the following are valid
Other Information